reduce noisy systrace sections (#46185)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/46185

changelog: [internal]

this is not needed anymore. let's remove it.

Reviewed By: dmytrorykun

Differential Revision: D61717151

fbshipit-source-id: 46f616e8170e653f0203c16ec76cfcfa948be153
This commit is contained in:
Samuel Susla
2024-08-26 15:52:22 -07:00
committed by Facebook GitHub Bot
parent 2a230694c4
commit d0f48c87bc
2 changed files with 0 additions and 9 deletions
@@ -10,7 +10,6 @@
#include <memory>
#include <vector>
#include <cxxreact/SystraceSection.h>
#include <react/debug/react_native_assert.h>
#include <react/renderer/core/ComponentDescriptor.h>
#include <react/renderer/core/EventDispatcher.h>
@@ -67,7 +66,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
std::shared_ptr<ShadowNode> createShadowNode(
const ShadowNodeFragment& fragment,
const ShadowNodeFamily::Shared& family) const override {
SystraceSection s("ConcreteComponentDescriptor::createShadowNode");
auto shadowNode =
std::make_shared<ShadowNodeT>(fragment, family, getTraits());
@@ -99,7 +97,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
const PropsParserContext& context,
const Props::Shared& props,
RawProps rawProps) const override {
SystraceSection s1("ConcreteComponentDescriptor::cloneProps");
// Optimization:
// Quite often nodes are constructed with default/empty props: the base
// `props` object is `null` (there no base because it's not cloning) and the
@@ -125,8 +122,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
#else
const auto& dynamic = static_cast<folly::dynamic>(rawProps);
#endif
SystraceSection s2(
"ConcreteComponentDescriptor::cloneProps - iterateOverValues");
for (const auto& pair : dynamic.items()) {
const auto& name = pair.first.getString();
shadowNodeProps->setProp(
@@ -137,8 +132,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
}
return shadowNodeProps;
} else {
SystraceSection s3(
"ConcreteComponentDescriptor::cloneProps - old-style constructor");
// Call old-style constructor
return ShadowNodeT::Props(context, rawProps, props);
}
@@ -162,7 +162,6 @@ RawProps& RawProps::operator=(const RawProps& other) noexcept {
}
void RawProps::parse(const RawPropsParser& parser) noexcept {
SystraceSection s("RawProps::parse");
react_native_assert(parser_ == nullptr && "A parser was already assigned.");
parser_ = &parser;
parser.preparse(*this);
@@ -174,7 +173,6 @@ void RawProps::parse(const RawPropsParser& parser) noexcept {
* will be removed as soon Android implementation does not need it.
*/
RawProps::operator folly::dynamic() const noexcept {
SystraceSection s("RawProps::operator folly::dynamic()");
switch (mode_) {
case Mode::Empty:
return folly::dynamic::object();