Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert D62398039: Speed up animation on back button press + animated reattach on tab switch

Browse Source 
Differential Revision:
D62398039

Original commit changeset: af286e428188

Original Phabricator Diff: D62398039

fbshipit-source-id: 9a69733d5a00c9081471096cca298579af468352
This commit is contained in:
Tim Yung
2024-09-12 13:34:32 -07:00
committed by Facebook GitHub Bot
parent 6b369a40d9
commit d0121a6c2d
1 changed files with 23 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/Animated/useAnimatedProps.js
Vendored
+23 -26
View File
@@ -22,7 +22,6 @@ import AnimatedValue from './nodes/AnimatedValue';
import {
useCallback,
useEffect,
useInsertionEffect,
useLayoutEffect,
useMemo,
useReducer,
@@ -323,8 +322,8 @@ function useAnimatedPropsLifecycle_layoutEffects(node: AnimatedProps): void {
* NOTE: unlike `useAnimatedPropsLifecycle_layoutEffects`, this version uses passive effects to setup animation graph.
*/
function useAnimatedPropsLifecycle_passiveEffects(node: AnimatedProps): void {
const attachedNodeRef =
useRef<?{node: AnimatedProps, listener: ?EventSubscription}>(null);
const prevNodeRef = useRef<?AnimatedProps>(null);
const isUnmountingRef = useRef<boolean>(false);
useEffect(() => {
// It is ok for multiple components to call `flushQueue` because it noops
@@ -333,45 +332,43 @@ function useAnimatedPropsLifecycle_passiveEffects(node: AnimatedProps): void {
NativeAnimatedHelper.API.flushQueue();
});
useInsertionEffect(() => {
useEffect(() => {
isUnmountingRef.current = false;
return () => {
const attachedNode = attachedNodeRef.current;
if (attachedNode != null) {
const {node: prevNode, listener} = attachedNode;
// NOTE: Do not restore default values on unmount, see D18197735.
prevNode.__detach();
listener?.remove();
attachedNodeRef.current = null;
}
isUnmountingRef.current = true;
};
}, []);
useEffect(() => {
let prevAttachedNode = null;
if (attachedNodeRef.current !== node) {
node.__attach();
prevAttachedNode = attachedNodeRef.current;
let listener: ?EventSubscription = null;
node.__attach();
let drivenAnimationEndedListener: ?EventSubscription = null;
if (node.__isNative) {
listener = NativeAnimatedHelper.nativeEventEmitter.addListener(
if (node.__isNative) {
drivenAnimationEndedListener =
NativeAnimatedHelper.nativeEventEmitter.addListener(
'onUserDrivenAnimationEnded',
data => {
node.update();
},
);
}
attachedNodeRef.current = {node, listener};
}
if (prevAttachedNode != null) {
const {node: prevNode, listener} = prevAttachedNode;
if (prevNodeRef.current != null) {
const prevNode = prevNodeRef.current;
// TODO: Stop restoring default values (unless `reset` is called).
prevNode.__restoreDefaultValues();
prevNode.__detach();
listener?.remove();
prevNodeRef.current = null;
}
return () => {
if (isUnmountingRef.current) {
// NOTE: Do not restore default values on unmount, see D18197735.
node.__detach();
} else {
prevNodeRef.current = node;
}
drivenAnimationEndedListener?.remove();
};
}, [node]);
}