mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix minor issues in UIManager (#55686)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55686 changelog: [internal] Small cleanup in UIManager Reviewed By: lenaic Differential Revision: D90330663 fbshipit-source-id: 0685725bb9d1f4d7d4c2aa5a76666ef0e01d9d21
This commit is contained in:
1 parent
1707d30025
commit
cfb91830a6
2 files changed
+6
-9
No files matched your search
@@ -469,7 +469,7 @@ void UIManager::setNativeProps_DEPRECATED(
|
||||
->getProps(),
|
||||
RawProps(rawProps));
|
||||
|
||||
return oldShadowNode.clone({/* .props = */ .props = props});
|
||||
return oldShadowNode.clone({.props = props});
|
||||
});
|
||||
|
||||
return std::static_pointer_cast<RootShadowNode>(rootNode);
|
||||
@@ -493,15 +493,12 @@ void UIManager::configureNextLayoutAnimation(
|
||||
const jsi::Value& failureCallback) const {
|
||||
if (animationDelegate_ != nullptr) {
|
||||
animationDelegate_->uiManagerDidConfigureNextLayoutAnimation(
|
||||
runtime,
|
||||
config,
|
||||
std::move(successCallback),
|
||||
std::move(failureCallback));
|
||||
runtime, config, successCallback, failureCallback);
|
||||
}
|
||||
}
|
||||
|
||||
static std::shared_ptr<const ShadowNode> findShadowNodeByTagRecursively(
|
||||
std::shared_ptr<const ShadowNode> parentShadowNode,
|
||||
const std::shared_ptr<const ShadowNode>& parentShadowNode,
|
||||
Tag tag) {
|
||||
if (parentShadowNode->getTag() == tag) {
|
||||
return parentShadowNode;
|
||||
|
||||
@@ -68,7 +68,7 @@ class UIManager final : public ShadowTreeDelegate {
|
||||
std::weak_ptr<UIManagerAnimationBackend> unstable_getAnimationBackend();
|
||||
|
||||
/**
|
||||
* Execute stopSurface on any UIMAnagerAnimationDelegate.
|
||||
* Execute stopSurface on any UIManagerAnimationDelegate.
|
||||
*/
|
||||
void stopSurfaceForAnimationDelegate(SurfaceId surfaceId) const;
|
||||
|
||||
@@ -79,9 +79,9 @@ class UIManager final : public ShadowTreeDelegate {
|
||||
void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
|
||||
|
||||
/*
|
||||
* Provides access to a UIManagerBindging.
|
||||
* Provides access to a UIManagerBinding.
|
||||
* The `callback` methods will not be called if the internal pointer to
|
||||
* `UIManagerBindging` is `nullptr`.
|
||||
* `UIManagerBinding` is `nullptr`.
|
||||
* The callback is called synchronously on the same thread.
|
||||
*/
|
||||
void visitBinding(
|
||||
|
||||
Reference in new issue
Block a user