Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Downgrade "packager disconnected" to a warning

Browse Source 
Summary:
If the error doesn't come in direct response to a user action, I think a redbox is too severe. I think we don't want to associate turning on Fast Refresh with a higher frequency of redboxes. So this downgrades these messages to warnings.

If you manually try to turn it off and on again, we'll still show a redbox to remind why it's not working.

Reviewed By: rickhanlonii, cpojer

Differential Revision: D15958952

fbshipit-source-id: bd144c98e87a9836871391ac583c268dca8009b3
This commit is contained in:
Dan Abramov
2019-06-24 13:54:39 -07:00
committed by Facebook Github Bot
parent a52e6d1dbb
commit cf7813a625
1 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Utilities/HMRClient.js
+10 -11
View File
@@ -29,6 +29,8 @@ const HMRClient = {
if (_hmrUnavailableReason !== null) {
// If HMR became unavailable while you weren't using it,
// explain why when you try to turn it on.
// This is an error (and not a warning) because it is shown
// in response to a direct user action.
throw new Error(_hmrUnavailableReason);
}
@@ -109,11 +111,11 @@ const HMRClient = {
let error = `Fast Refresh isn't working because it cannot connect to the development server.
Try the following to fix the issue:
- Ensure that the packager server is running and available on the same network`;
- Ensure that the Metro Server is running and available on the same network`;
if (Platform.OS === 'ios') {
error += `
- Ensure that the Packager server URL is correctly set in AppDelegate`;
- Ensure that the Metro server URL is correctly set in AppDelegate`;
} else {
error += `
- Ensure that your device/emulator is connected to your machine and has USB debugging enabled - run 'adb devices' to see a list of connected devices
@@ -182,15 +184,13 @@ Error: ${e.message}`;
if (data.type === 'GraphNotFoundError') {
hmrClient.disable();
// TODO: this shouldn't be a redbox.
setHMRUnavailableReason(
'The packager server has restarted since the last edit. Fast Refresh will be disabled until you reload the application.',
'The Metro server has restarted since the last edit. Fast Refresh will be disabled until you reload the application.',
);
} else if (data.type === 'RevisionNotFoundError') {
hmrClient.disable();
// TODO: this shouldn't be a redbox.
setHMRUnavailableReason(
'The packager server and the client are out of sync. Fast Refresh will be disabled until you reload the application.',
'The Metro server and the client are out of sync. Fast Refresh will be disabled until you reload the application.',
);
} else {
throw new Error(`${data.type} ${data.message}`);
@@ -199,9 +199,8 @@ Error: ${e.message}`;
hmrClient.on('close', data => {
HMRLoadingView.hide();
// TODO: this shouldn't be a redbox.
setHMRUnavailableReason(
'Disconnected from the packager server. Fast Refresh will be disabled until you reload the application.',
'Disconnected from the Metro server. Fast Refresh will be disabled until you reload the application.',
);
});
@@ -218,9 +217,9 @@ function setHMRUnavailableReason(reason) {
_hmrUnavailableReason = reason;
if (_hmrClient.shouldApplyUpdates) {
// If HMR is currently enabled, show the error right away.
// Otherwise, it will be shown when you try to enable it.
throw new Error(reason);
// If HMR is currently enabled, show a warning.
console.warn(reason);
// (Not using the `warning` module to prevent a Buck cycle.)
}
}