Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup rn_ama_new_arch_ios.bridge_batch_did_complete_fix (#50598)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50598

changelog: [ios][breaking] delete BridgeModuleBatchDidComplete config helpers

this is not used anywhere, cleanup

Reviewed By: srinathvijay

Differential Revision: D72692359

fbshipit-source-id: 42220a64be59bc0d32efe76c1f1d8fc4508a6b0e
This commit is contained in:
Phillip Pan
2025-04-09 18:17:57 -07:00
committed by Facebook GitHub Bot
parent 89bcbed1a5
commit cbad8aafa5
3 changed files with 6 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Base/RCTBridge.h
-3
View File
@@ -82,9 +82,6 @@ void RCTSetTurboModuleInteropBridgeProxyLogLevel(RCTBridgeProxyLoggingLevel logL
BOOL RCTTurboModuleInteropForAllTurboModulesEnabled(void);
void RCTEnableTurboModuleInteropForAllTurboModules(BOOL enabled);
BOOL RCTBridgeModuleBatchDidCompleteDisabled(void);
void RCTDisableBridgeModuleBatchDidComplete(BOOL disabled);
typedef enum {
kRCTGlobalScope,
kRCTGlobalScopeUsingRetainJSCallback,
packages/react-native/React/Base/RCTBridge.mm
-11
View File
@@ -254,17 +254,6 @@ void RCTEnableTurboModuleSyncVoidMethods(BOOL enabled)
gTurboModuleEnableSyncVoidMethods = enabled;
}
static BOOL gBridgeModuleDisableBatchDidComplete = NO;
BOOL RCTBridgeModuleBatchDidCompleteDisabled(void)
{
return gBridgeModuleDisableBatchDidComplete;
}
void RCTDisableBridgeModuleBatchDidComplete(BOOL disabled)
{
gBridgeModuleDisableBatchDidComplete = disabled;
}
BOOL kDispatchAccessibilityManagerInitOntoMain = NO;
BOOL RCTUIManagerDispatchAccessibilityManagerInitOntoMain(void)
{
packages/react-native/React/CxxBridge/RCTCxxBridge.mm
+6 -18
View File
@@ -1458,27 +1458,15 @@ RCT_NOT_IMPLEMENTED(-(instancetype)initWithBundleURL
- (void)batchDidComplete
{
if (RCTBridgeModuleBatchDidCompleteDisabled()) {
id uiManager = [self moduleForName:@"UIManager"];
if ([uiManager respondsToSelector:@selector(batchDidComplete)] &&
[uiManager respondsToSelector:@selector(methodQueue)]) {
// TODO #12592471: batchDidComplete is only used by RCTUIManager,
// can we eliminate this special case?
for (RCTModuleData *moduleData in _moduleDataByID) {
if (moduleData.implementsBatchDidComplete) {
[self
dispatchBlock:^{
[uiManager batchDidComplete];
[moduleData.instance batchDidComplete];
}
queue:[uiManager methodQueue]];
}
} else {
// TODO #12592471: batchDidComplete is only used by RCTUIManager,
// can we eliminate this special case?
for (RCTModuleData *moduleData in _moduleDataByID) {
if (moduleData.implementsBatchDidComplete) {
[self
dispatchBlock:^{
[moduleData.instance batchDidComplete];
}
queue:moduleData.methodQueue];
}
queue:moduleData.methodQueue];
}
}
}