Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix clang warning for -Winconsistent-missing-destructor-override (#42942)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42942

Instance derives from jsinspector_modern::InstanceTargetDelegate, which defines a virtual destructor, but Instance does not mark its destructor with override.

## Changelog [Internal]

Reviewed By: cipolleschi

Differential Revision: D53609922

fbshipit-source-id: b30df7d59478fa72b53ddc2eeb04c291a6f5f9eb
This commit is contained in:
Eric Rozell
2024-02-09 06:31:31 -08:00
committed by Facebook GitHub Bot
parent f6f461593b
commit cadaf26cde
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/cxxreact/Instance.h
+1 -1
View File
@@ -41,7 +41,7 @@ struct InstanceCallback {
class RN_EXPORT Instance : private jsinspector_modern::InstanceTargetDelegate {
public:
~Instance();
~Instance() override;
void initializeBridge(
std::unique_ptr<InstanceCallback> callback,
std::shared_ptr<JSExecutorFactory> jsef,