Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/PromiseImpl.java

Browse Source 
Summary:
Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: alanleedev

Differential Revision: D72384080

fbshipit-source-id: f859a21826bd1dd9d6fa0da82df5a4f0e9e79264
This commit is contained in:
Gijs Weterings
2025-04-09 09:07:30 -07:00
committed by Facebook GitHub Bot
parent 8aaccef2ee
commit cad6f78f12
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/PromiseImpl.java
+6
View File
@@ -55,6 +55,7 @@ public class PromiseImpl implements Promise {
* @param value Object
*/
@Override
// NULLSAFE_FIXME[Inconsistent Subclass Parameter Annotation]
public void resolve(Object value) {
if (mResolve != null) {
mResolve.invoke(value);
@@ -70,6 +71,7 @@ public class PromiseImpl implements Promise {
* @param message String
*/
@Override
// NULLSAFE_FIXME[Inconsistent Subclass Parameter Annotation]
public void reject(String code, String message) {
reject(code, message, /*Throwable*/ null, /*WritableMap*/ null);
}
@@ -81,6 +83,7 @@ public class PromiseImpl implements Promise {
* @param throwable Throwable
*/
@Override
// NULLSAFE_FIXME[Inconsistent Subclass Parameter Annotation]
public void reject(String code, Throwable throwable) {
reject(code, /*Message*/ null, throwable, /*WritableMap*/ null);
}
@@ -93,6 +96,7 @@ public class PromiseImpl implements Promise {
* @param throwable Throwable
*/
@Override
// NULLSAFE_FIXME[Inconsistent Subclass Parameter Annotation]
public void reject(String code, String message, Throwable throwable) {
reject(code, message, throwable, /*WritableMap*/ null);
}
@@ -143,6 +147,7 @@ public class PromiseImpl implements Promise {
* @param userInfo WritableMap
*/
@Override
// NULLSAFE_FIXME[Inconsistent Subclass Parameter Annotation]
public void reject(String code, Throwable throwable, WritableMap userInfo) {
reject(code, /*Message*/ null, throwable, userInfo);
}
@@ -156,6 +161,7 @@ public class PromiseImpl implements Promise {
* @param userInfo WritableMap
*/
@Override
// NULLSAFE_FIXME[Inconsistent Subclass Parameter Annotation]
public void reject(String code, String message, @NonNull WritableMap userInfo) {
reject(code, message, /*Throwable*/ null, userInfo);
}