Fix React-Codegen dependencies on FabricImage (#41640)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41640

react-native-svg reported that the SVG library was not building on the latest RC of React Native because Codegen was not finding the proper files.

By inspecting an example app with SVG, we realized that React-Codegen was not depending on `React-FabricImage`, while having access to their headers.

We added the dependency, but them the build was failing due to a circular dependency because the `React-ImageManager` was dependeing on `React-RCTImage`.
This dependency is conceptually wrong (a piece of Core should not depend on Library which depends on Core... 😑) and I verified that by removing that dependency the framework continue to build.

## Changelog:
[Internal] - Fixed dependencies of Codegen on React-Image

Reviewed By: cortinico

Differential Revision: D51564037

fbshipit-source-id: 8e7108b83f878be1063df5562311d862d4998121
This commit is contained in:
Riccardo Cipolleschi
2023-11-25 11:39:15 -08:00
committed by Facebook GitHub Bot
parent 4016bfbc37
commit caae388912
3 changed files with 3 additions and 1 deletions
@@ -56,7 +56,6 @@ Pod::Spec.new do |s|
s.dependency "RCT-Folly/Fabric"
s.dependency "React-Core/Default"
s.dependency "React-RCTImage"
s.dependency "glog"
add_dependency(s, "React-Fabric")
@@ -559,6 +559,7 @@ class CodegenUtilsTests < Test::Unit::TestCase
specs[:dependencies].merge!({
'React-graphics': [],
'React-Fabric': [],
'React-FabricImage': [],
'React-utils': [],
'React-debug': [],
'React-rendererdebug': [],
@@ -578,6 +579,7 @@ class CodegenUtilsTests < Test::Unit::TestCase
specs[:dependencies].merge!({
'React-graphics': [],
'React-Fabric': [],
'React-FabricImage': [],
'React-utils': [],
'React-debug': [],
'React-rendererdebug': [],
@@ -138,6 +138,7 @@ class CodegenUtils
'React-graphics': [],
'React-rendererdebug': [],
'React-Fabric': [],
'React-FabricImage': [],
'React-debug': [],
'React-utils': [],
}