Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove unimplemented methods (#51607)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/51607

changelog: [internal]

remove methods that are not implemented yet.

Reviewed By: rshest

Differential Revision: D75148726

fbshipit-source-id: c01002050dc9c71df559e6f89b72aeee46e3a2f6
This commit is contained in:
Samuel Susla
2025-05-26 09:29:00 -07:00
committed by Facebook GitHub Bot
parent 8a0cfec815
commit c653eea19d
3 changed files with 4 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedModule.cpp
+4 -14
View File
@@ -54,11 +54,7 @@ void AnimatedModule::updateAnimatedNodeConfig(
jsi::Runtime& rt,
Tag tag,
jsi::Object config) {
auto configDynamic = dynamicFromValue(rt, jsi::Value(rt, config));
addOperation([tag, configDynamic = std::move(configDynamic)](
NativeAnimatedNodesManager& nodesManager) {
nodesManager.updateAnimatedNodeConfig(tag, configDynamic);
});
// TODO: missing implementation
}
void AnimatedModule::getValue(
@@ -164,25 +160,19 @@ void AnimatedModule::setAnimatedNodeOffset(
jsi::Runtime& /*rt*/,
Tag nodeTag,
double offset) {
addOperation([nodeTag, offset](NativeAnimatedNodesManager& nodesManager) {
nodesManager.setAnimatedNodeOffset(nodeTag, offset);
});
// TODO: missing implementation
}
void AnimatedModule::flattenAnimatedNodeOffset(
jsi::Runtime& /*rt*/,
Tag nodeTag) {
addOperation([nodeTag](NativeAnimatedNodesManager& nodesManager) {
nodesManager.flattenAnimatedNodeOffset(nodeTag);
});
// TODO: missing implementation
}
void AnimatedModule::extractAnimatedNodeOffset(
jsi::Runtime& /*rt*/,
Tag nodeTag) {
addOperation([nodeTag](NativeAnimatedNodesManager& nodesManager) {
nodesManager.extractAnimatedNodeOffset(nodeTag);
});
// TODO: missing implementation
}
void AnimatedModule::connectAnimatedNodeToView(
packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp
-22
View File
@@ -253,28 +253,6 @@ void NativeAnimatedNodesManager::stopAnimationsForNode(Tag nodeTag) {
}
}
void NativeAnimatedNodesManager::setAnimatedNodeOffset(
Tag /*tag*/,
double /*offset*/) noexcept {
LOG(WARNING) << "SetAnimatedNodeOffset is unimplemented";
}
void NativeAnimatedNodesManager::flattenAnimatedNodeOffset(
Tag /*tag*/) noexcept {
LOG(WARNING) << "FlattenAnimatedNodeOffset is unimplemented";
}
void NativeAnimatedNodesManager::extractAnimatedNodeOffset(
Tag /*tag*/) noexcept {
LOG(WARNING) << "ExtractAnimatedNodeOffset is unimplemented";
}
void NativeAnimatedNodesManager::updateAnimatedNodeConfig(
Tag /*tag*/,
const folly::dynamic& /*config*/) noexcept {
LOG(WARNING) << "UpdateAnimatedNodeConfig is unimplemented";
}
// drivers
void NativeAnimatedNodesManager::startAnimatingNode(
packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.h
-10
View File
@@ -88,18 +88,8 @@ class NativeAnimatedNodesManager {
void dropAnimatedNode(Tag tag) noexcept;
// mutations
void setAnimatedNodeValue(Tag tag, double value);
void setAnimatedNodeOffset(Tag tag, double offset) noexcept;
void flattenAnimatedNodeOffset(Tag tag) noexcept;
void extractAnimatedNodeOffset(Tag tag) noexcept;
void updateAnimatedNodeConfig(Tag tag, const folly::dynamic& config) noexcept;
// drivers
void startAnimatingNode(