mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Adding AlertOptions to ts Alert.prompt function (#35957)
Summary: Bringing the typescript function signature in-line with the js code. ## Changelog [GENERAL] [FIXED] - Added AlertOptions argument to the type definition for Alert.prompt to bring it into parity with the js code. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: https://github.com/facebook/react-native/pull/35957 Test Plan: Before the change, VS Code would show a typescript error when I pass AlertOptions to Alert.prompt (even though the js would execute successfully and respect the options I passed. After the change, when I use an Alert.prompt in VS code the function signature was recognized without errors. Reviewed By: christophpurrer Differential Revision: D42737818 Pulled By: jacdebug fbshipit-source-id: 4d4318f38f5c7b7302aae62de5ce224db67e088a
This commit is contained in:
committed by
Lorenzo Sciandra
parent
e13929eae3
commit
c4a995d59a
Vendored
+1
@@ -77,6 +77,7 @@ export interface AlertStatic {
|
||||
type?: AlertType,
|
||||
defaultValue?: string,
|
||||
keyboardType?: string,
|
||||
options?: AlertOptions,
|
||||
) => void;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user