Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not show setup logs from createPerformanceLogger unless logs are enabled for it

Browse Source 
Summary: This module logs helpful messages in `__DEV__` but it only logs actionable performance logs when the flag on top of the file is enabled. This diff changes those to only log when the toggle on top of the file is enabled as well.

Reviewed By: gaearon

Differential Revision: D16107933

fbshipit-source-id: 7671bc521af984d617a0f5ffc0eacd1aa5674a62
This commit is contained in:
Christoph Nakazawa
2019-07-04 02:50:58 -07:00
committed by Facebook Github Bot
parent d57cdac62b
commit c31fa2a45d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Utilities/createPerformanceLogger.js
+6 -6
View File
@@ -67,7 +67,7 @@ function createPerformanceLogger(): IPerformanceLogger {
addTimespan(key: string, lengthInMs: number, description?: string) {
if (this._timespans[key]) {
if (__DEV__) {
if (PRINT_TO_CONSOLE && __DEV__) {
infoLog(
'PerformanceLogger: Attempting to add a timespan that already exists ',
key,
@@ -84,7 +84,7 @@ function createPerformanceLogger(): IPerformanceLogger {
startTimespan(key: string, description?: string) {
if (this._timespans[key]) {
if (__DEV__) {
if (PRINT_TO_CONSOLE && __DEV__) {
infoLog(
'PerformanceLogger: Attempting to start a timespan that already exists ',
key,
@@ -106,7 +106,7 @@ function createPerformanceLogger(): IPerformanceLogger {
stopTimespan(key: string) {
const timespan = this._timespans[key];
if (!timespan || !timespan.startTime) {
if (__DEV__) {
if (PRINT_TO_CONSOLE && __DEV__) {
infoLog(
'PerformanceLogger: Attempting to end a timespan that has not started ',
key,
@@ -115,7 +115,7 @@ function createPerformanceLogger(): IPerformanceLogger {
return;
}
if (timespan.endTime) {
if (__DEV__) {
if (PRINT_TO_CONSOLE && __DEV__) {
infoLog(
'PerformanceLogger: Attempting to end a timespan that has already ended ',
key,
@@ -203,7 +203,7 @@ function createPerformanceLogger(): IPerformanceLogger {
setExtra(key: string, value: any) {
if (this._extras[key]) {
if (__DEV__) {
if (PRINT_TO_CONSOLE && __DEV__) {
infoLog(
'PerformanceLogger: Attempting to set an extra that already exists ',
{key, currentValue: this._extras[key], attemptedValue: value},
@@ -230,7 +230,7 @@ function createPerformanceLogger(): IPerformanceLogger {
markPoint(key: string, timestamp?: number) {
if (this._points[key]) {
if (__DEV__) {
if (PRINT_TO_CONSOLE && __DEV__) {
infoLog(
'PerformanceLogger: Attempting to mark a point that has been already logged ',
key,