Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use ConcreteStateTeller in RCTModalHostViewComponentView

Browse Source 
Summary: Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D23239096

fbshipit-source-id: b82301e5db48861d6d241abd681df38701e3ac44
This commit is contained in:
Samuel Susla
2020-08-24 06:39:29 -07:00
committed by Facebook GitHub Bot
parent ca091b009a
commit c2dab01c62
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm
+6 -9
View File
@@ -100,7 +100,7 @@ static ModalHostViewEventEmitter::OnOrientationChange onOrientationChangeStruct(
@implementation RCTModalHostViewComponentView {
RCTFabricModalHostViewController *_viewController;
ModalHostViewShadowNode::ConcreteState::Shared _state;
ModalHostViewShadowNode::ConcreteStateTeller _stateTeller;
BOOL _shouldAnimatePresentation;
BOOL _isPresented;
}
@@ -182,10 +182,8 @@ static ModalHostViewEventEmitter::OnOrientationChange onOrientationChangeStruct(
eventEmitter->onOrientationChange(onOrientationChangeStruct(newBounds));
}
if (_state != nullptr) {
auto newState = ModalHostViewState{RCTSizeFromCGSize(newBounds.size)};
_state->updateState(std::move(newState));
}
auto newState = ModalHostViewState{RCTSizeFromCGSize(newBounds.size)};
_stateTeller.updateState(std::move(newState));
}
#pragma mark - RCTComponentViewProtocol
@@ -198,7 +196,7 @@ static ModalHostViewEventEmitter::OnOrientationChange onOrientationChangeStruct(
- (void)prepareForRecycle
{
[super prepareForRecycle];
_state.reset();
_stateTeller.invalidate();
_isPresented = NO;
}
@@ -219,10 +217,9 @@ static ModalHostViewEventEmitter::OnOrientationChange onOrientationChangeStruct(
[super updateProps:props oldProps:oldProps];
}
- (void)updateState:(facebook::react::State::Shared const &)state
oldState:(facebook::react::State::Shared const &)oldState
- (void)updateState:(State::Shared const &)state oldState:(State::Shared const &)oldState
{
_state = std::static_pointer_cast<const ModalHostViewShadowNode::ConcreteState>(state);
_stateTeller.setConcreteState(state);
}
- (void)mountChildComponentView:(UIView<RCTComponentViewProtocol> *)childComponentView index:(NSInteger)index