mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix type in BlobCollector.h/cpp (#41404)
Summary: When working on JSI module, `BlobCollector`'s `nativeInstall` is a good example. But the first type should be `jni::alias_ref<jclass>` according to https://github.com/facebookincubator/fbjni/blob/main/docs/quickref.md#basic-method-usage-java-to-c-and-c-to-java Fix type in BlobCollector.h/cpp ## Changelog: [ANDROID] [FIXED] - Fix type in BlobCollector.h/cpp Pull Request resolved: https://github.com/facebook/react-native/pull/41404 Test Plan: None Reviewed By: cipolleschi Differential Revision: D51198049 Pulled By: javache fbshipit-source-id: 86f471cbe3cd683a7be605ce127b3b3c3769c037
This commit is contained in:
committed by
Facebook GitHub Bot
parent
88e3913603
commit
c267a0679d
+1
-1
@@ -33,7 +33,7 @@ BlobCollector::~BlobCollector() {
|
||||
}
|
||||
|
||||
void BlobCollector::nativeInstall(
|
||||
jni::alias_ref<jhybridobject> jThis,
|
||||
jni::alias_ref<jclass>,
|
||||
jni::alias_ref<jobject> blobModule,
|
||||
jlong jsContextNativePointer) {
|
||||
auto& runtime = *((jsi::Runtime*)jsContextNativePointer);
|
||||
|
||||
+2
-4
@@ -15,16 +15,14 @@ namespace facebook::react {
|
||||
class BlobCollector : public jni::HybridClass<BlobCollector>,
|
||||
public jsi::HostObject {
|
||||
public:
|
||||
BlobCollector(
|
||||
jni::global_ref<jobject> blobManager,
|
||||
const std::string& blobId);
|
||||
BlobCollector(jni::global_ref<jobject> blobModule, const std::string& blobId);
|
||||
~BlobCollector();
|
||||
|
||||
static constexpr auto kJavaDescriptor =
|
||||
"Lcom/facebook/react/modules/blob/BlobCollector;";
|
||||
|
||||
static void nativeInstall(
|
||||
jni::alias_ref<jhybridobject> jThis,
|
||||
jni::alias_ref<jclass>,
|
||||
jni::alias_ref<jobject> blobModule,
|
||||
jlong jsContextNativePointer);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user