Remove syncAndroidClipToPaddingWithOverflow feature flag (#56467)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/56467

Remove the `syncAndroidClipToPaddingWithOverflow` feature flag and all associated logic.
This flag synced Android `clipToPadding` with the CSS `overflow` property, but
`clipToPadding` has no effect when padding is 0 (the default for most RN views),
making the entire mechanism insufficient. We will replace this with `setClipBounds()`
in a follow-up diff (T253147322).

- Remove clipToPadding logic from `ReactViewGroup.initView()` and `overflow` setter
- Remove `getClipToPadding()` overrides from ReactScrollView, ReactHorizontalScrollView
- Regenerate ReactNestedScrollView from updated ReactScrollView source
- Remove hardcoded override from ReactNativeFeatureFlagsOverrides_PanelApp
- Remove flag definition from ReactNativeFeatureFlags.config.js and regenerate all
  feature flag infrastructure files

Changelog: [Internal]

Reviewed By: zeyap

Differential Revision: D101153619

fbshipit-source-id: c9bbe610cc69b8c484b5b3a309d1cffa606ff8e0
This commit is contained in:
Fabrizio Cucci authored and meta-codesync[bot] committed 2026-04-23 23:44:54 -07:00
1 parent d11aedd621
commit c0adceaa3d
25 files changed
+37 -185

No files matched your search

@@ -5540,7 +5540,6 @@ public class com/facebook/react/views/scroll/ReactHorizontalScrollView : android
public fun fling (I)V
public fun focusSearch (Landroid/view/View;I)Landroid/view/View;
public fun getChildVisibleRect (Landroid/view/View;Landroid/graphics/Rect;Landroid/graphics/Point;)Z
public fun getClipToPadding ()Z
public fun getClippingRect (Landroid/graphics/Rect;)V
public fun getFadingEdgeLengthEnd ()I
public fun getFadingEdgeLengthStart ()I
@@ -5686,7 +5685,6 @@ public class com/facebook/react/views/scroll/ReactScrollView : android/widget/Sc
public fun focusSearch (Landroid/view/View;I)Landroid/view/View;
protected fun getBottomFadingEdgeStrength ()F
public fun getChildVisibleRect (Landroid/view/View;Landroid/graphics/Rect;Landroid/graphics/Point;)Z
public fun getClipToPadding ()Z
public fun getClippingRect (Landroid/graphics/Rect;)V
public fun getFadingEdgeLengthEnd ()I
public fun getFadingEdgeLengthStart ()I
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<82da59cbfb06937bba284ff1df2c64d6>>
* @generated SignedSource<<eb70fd41bc36f1a49849e29bea081007>>
*/
/**
@@ -480,12 +480,6 @@ public object ReactNativeFeatureFlags {
@JvmStatic
public fun skipActivityIdentityAssertionOnHostPause(): Boolean = accessor.skipActivityIdentityAssertionOnHostPause()
/**
* Sync clipToPadding on Android views with the overflow property
*/
@JvmStatic
public fun syncAndroidClipToPaddingWithOverflow(): Boolean = accessor.syncAndroidClipToPaddingWithOverflow()
/**
* Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
*/
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<b6d6b8aae3449760d857e5dd52588b03>>
* @generated SignedSource<<f79ca61a0da053a1661eca4d3a35b081>>
*/
/**
@@ -95,7 +95,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
private var shouldPressibilityUseW3CPointerEventsForHoverCache: Boolean? = null
private var shouldTriggerResponderTransferOnScrollAndroidCache: Boolean? = null
private var skipActivityIdentityAssertionOnHostPauseCache: Boolean? = null
private var syncAndroidClipToPaddingWithOverflowCache: Boolean? = null
private var traceTurboModulePromiseRejectionsOnAndroidCache: Boolean? = null
private var updateRuntimeShadowNodeReferencesOnCommitCache: Boolean? = null
private var updateRuntimeShadowNodeReferencesOnCommitThreadCache: Boolean? = null
@@ -788,15 +787,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
return cached
}
override fun syncAndroidClipToPaddingWithOverflow(): Boolean {
var cached = syncAndroidClipToPaddingWithOverflowCache
if (cached == null) {
cached = ReactNativeFeatureFlagsCxxInterop.syncAndroidClipToPaddingWithOverflow()
syncAndroidClipToPaddingWithOverflowCache = cached
}
return cached
}
override fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean {
var cached = traceTurboModulePromiseRejectionsOnAndroidCache
if (cached == null) {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<7ca56a7b519e6e1619931447dcc1672a>>
* @generated SignedSource<<62d1f0fcdf8e3165480da12575d62826>>
*/
/**
@@ -178,8 +178,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
@DoNotStrip @JvmStatic public external fun skipActivityIdentityAssertionOnHostPause(): Boolean
@DoNotStrip @JvmStatic public external fun syncAndroidClipToPaddingWithOverflow(): Boolean
@DoNotStrip @JvmStatic public external fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean
@DoNotStrip @JvmStatic public external fun updateRuntimeShadowNodeReferencesOnCommit(): Boolean
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<fe424de3f03b5f2ee20b83896eef01b1>>
* @generated SignedSource<<84ac5b80585f9185c879c81822718d86>>
*/
/**
@@ -173,8 +173,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
override fun skipActivityIdentityAssertionOnHostPause(): Boolean = false
override fun syncAndroidClipToPaddingWithOverflow(): Boolean = false
override fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean = false
override fun updateRuntimeShadowNodeReferencesOnCommit(): Boolean = false
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<0de759cf10c9d77c9938f9dac257aada>>
* @generated SignedSource<<3574e23fe8f846e408964af26cf0dd4c>>
*/
/**
@@ -99,7 +99,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
private var shouldPressibilityUseW3CPointerEventsForHoverCache: Boolean? = null
private var shouldTriggerResponderTransferOnScrollAndroidCache: Boolean? = null
private var skipActivityIdentityAssertionOnHostPauseCache: Boolean? = null
private var syncAndroidClipToPaddingWithOverflowCache: Boolean? = null
private var traceTurboModulePromiseRejectionsOnAndroidCache: Boolean? = null
private var updateRuntimeShadowNodeReferencesOnCommitCache: Boolean? = null
private var updateRuntimeShadowNodeReferencesOnCommitThreadCache: Boolean? = null
@@ -867,16 +866,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
return cached
}
override fun syncAndroidClipToPaddingWithOverflow(): Boolean {
var cached = syncAndroidClipToPaddingWithOverflowCache
if (cached == null) {
cached = currentProvider.syncAndroidClipToPaddingWithOverflow()
accessedFeatureFlags.add("syncAndroidClipToPaddingWithOverflow")
syncAndroidClipToPaddingWithOverflowCache = cached
}
return cached
}
override fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean {
var cached = traceTurboModulePromiseRejectionsOnAndroidCache
if (cached == null) {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<dd7ae1c5f86fa273402e5b64a8636528>>
* @generated SignedSource<<9222fd90d191a91893e2c58770d83259>>
*/
/**
@@ -173,8 +173,6 @@ public interface ReactNativeFeatureFlagsProvider {
@DoNotStrip public fun skipActivityIdentityAssertionOnHostPause(): Boolean
@DoNotStrip public fun syncAndroidClipToPaddingWithOverflow(): Boolean
@DoNotStrip public fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean
@DoNotStrip public fun updateRuntimeShadowNodeReferencesOnCommit(): Boolean
@@ -461,14 +461,6 @@ public class ReactHorizontalScrollView extends HorizontalScrollView
return mOverflowInset;
}
@Override
public boolean getClipToPadding() {
if (ReactNativeFeatureFlags.syncAndroidClipToPaddingWithOverflow()) {
return mOverflow != Overflow.VISIBLE;
}
return super.getClipToPadding();
}
@Override
public void onDraw(Canvas canvas) {
if (mOverflow != Overflow.VISIBLE) {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<74209bb4a44619a1ce16d68cfeeb0653>>
* @generated SignedSource<<a0490be2c6f7eb42376e8e64abf9ce5e>>
*/
/**
@@ -788,14 +788,6 @@ class ReactNestedScrollView extends NestedScrollView
}
}
@Override
public boolean getClipToPadding() {
if (ReactNativeFeatureFlags.syncAndroidClipToPaddingWithOverflow()) {
return mOverflow != Overflow.VISIBLE;
}
return super.getClipToPadding();
}
@Override
public void getClippingRect(Rect outClippingRect) {
outClippingRect.set(Assertions.assertNotNull(mClippingRect));
@@ -780,14 +780,6 @@ public class ReactScrollView extends ScrollView
}
}
@Override
public boolean getClipToPadding() {
if (ReactNativeFeatureFlags.syncAndroidClipToPaddingWithOverflow()) {
return mOverflow != Overflow.VISIBLE;
}
return super.getClipToPadding();
}
@Override
public void getClippingRect(Rect outClippingRect) {
outClippingRect.set(Assertions.assertNotNull(mClippingRect));
@@ -164,9 +164,6 @@ public open class ReactViewGroup public constructor(context: Context?) :
*/
private fun initView() {
clipChildren = false
if (ReactNativeFeatureFlags.syncAndroidClipToPaddingWithOverflow()) {
clipToPadding = false
}
_removeClippedSubviews = false
inSubviewClippingLoop = false
@@ -820,9 +817,6 @@ public open class ReactViewGroup public constructor(context: Context?) :
} else {
Overflow.fromString(overflow)
}
if (ReactNativeFeatureFlags.syncAndroidClipToPaddingWithOverflow()) {
clipToPadding = _overflow != Overflow.VISIBLE
}
invalidate()
}
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<411aef7b1b977407b52e4f23e95db0a5>>
* @generated SignedSource<<e8cf371a99a72250ea1b0104dc7f8254>>
*/
/**
@@ -489,12 +489,6 @@ class ReactNativeFeatureFlagsJavaProvider
return method(javaProvider_);
}
bool syncAndroidClipToPaddingWithOverflow() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("syncAndroidClipToPaddingWithOverflow");
return method(javaProvider_);
}
bool traceTurboModulePromiseRejectionsOnAndroid() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("traceTurboModulePromiseRejectionsOnAndroid");
@@ -970,11 +964,6 @@ bool JReactNativeFeatureFlagsCxxInterop::skipActivityIdentityAssertionOnHostPaus
return ReactNativeFeatureFlags::skipActivityIdentityAssertionOnHostPause();
}
bool JReactNativeFeatureFlagsCxxInterop::syncAndroidClipToPaddingWithOverflow(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::syncAndroidClipToPaddingWithOverflow();
}
bool JReactNativeFeatureFlagsCxxInterop::traceTurboModulePromiseRejectionsOnAndroid(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::traceTurboModulePromiseRejectionsOnAndroid();
@@ -1311,9 +1300,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
makeNativeMethod(
"skipActivityIdentityAssertionOnHostPause",
JReactNativeFeatureFlagsCxxInterop::skipActivityIdentityAssertionOnHostPause),
makeNativeMethod(
"syncAndroidClipToPaddingWithOverflow",
JReactNativeFeatureFlagsCxxInterop::syncAndroidClipToPaddingWithOverflow),
makeNativeMethod(
"traceTurboModulePromiseRejectionsOnAndroid",
JReactNativeFeatureFlagsCxxInterop::traceTurboModulePromiseRejectionsOnAndroid),
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<7b397abbf52289b37f424eef8e689cc8>>
* @generated SignedSource<<773741594e911047dac28904e9fc9544>>
*/
/**
@@ -255,9 +255,6 @@ class JReactNativeFeatureFlagsCxxInterop
static bool skipActivityIdentityAssertionOnHostPause(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
static bool syncAndroidClipToPaddingWithOverflow(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
static bool traceTurboModulePromiseRejectionsOnAndroid(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<505f532777eb5c18637f61b824600234>>
* @generated SignedSource<<6a15a6444767342acf4da0c0c8aa6208>>
*/
/**
@@ -326,10 +326,6 @@ bool ReactNativeFeatureFlags::skipActivityIdentityAssertionOnHostPause() {
return getAccessor().skipActivityIdentityAssertionOnHostPause();
}
bool ReactNativeFeatureFlags::syncAndroidClipToPaddingWithOverflow() {
return getAccessor().syncAndroidClipToPaddingWithOverflow();
}
bool ReactNativeFeatureFlags::traceTurboModulePromiseRejectionsOnAndroid() {
return getAccessor().traceTurboModulePromiseRejectionsOnAndroid();
}
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<ec9479d555f4e08095fbde0bfd09c479>>
* @generated SignedSource<<62d1840f9a39eaceaa800542b7351a41>>
*/
/**
@@ -414,11 +414,6 @@ class ReactNativeFeatureFlags {
*/
RN_EXPORT static bool skipActivityIdentityAssertionOnHostPause();
/**
* Sync clipToPadding on Android views with the overflow property
*/
RN_EXPORT static bool syncAndroidClipToPaddingWithOverflow();
/**
* Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
*/
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c50301c8f290cf0bb338a606c1cc518f>>
* @generated SignedSource<<b0ed71a14e0bd06787b6d2213422d8de>>
*/
/**
@@ -1379,24 +1379,6 @@ bool ReactNativeFeatureFlagsAccessor::skipActivityIdentityAssertionOnHostPause()
return flagValue.value();
}
bool ReactNativeFeatureFlagsAccessor::syncAndroidClipToPaddingWithOverflow() {
auto flagValue = syncAndroidClipToPaddingWithOverflow_.load();
if (!flagValue.has_value()) {
// This block is not exclusive but it is not necessary.
// If multiple threads try to initialize the feature flag, we would only
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(75, "syncAndroidClipToPaddingWithOverflow");
flagValue = currentProvider_->syncAndroidClipToPaddingWithOverflow();
syncAndroidClipToPaddingWithOverflow_ = flagValue;
}
return flagValue.value();
}
bool ReactNativeFeatureFlagsAccessor::traceTurboModulePromiseRejectionsOnAndroid() {
auto flagValue = traceTurboModulePromiseRejectionsOnAndroid_.load();
@@ -1406,7 +1388,7 @@ bool ReactNativeFeatureFlagsAccessor::traceTurboModulePromiseRejectionsOnAndroid
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(76, "traceTurboModulePromiseRejectionsOnAndroid");
markFlagAsAccessed(75, "traceTurboModulePromiseRejectionsOnAndroid");
flagValue = currentProvider_->traceTurboModulePromiseRejectionsOnAndroid();
traceTurboModulePromiseRejectionsOnAndroid_ = flagValue;
@@ -1424,7 +1406,7 @@ bool ReactNativeFeatureFlagsAccessor::updateRuntimeShadowNodeReferencesOnCommit(
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(77, "updateRuntimeShadowNodeReferencesOnCommit");
markFlagAsAccessed(76, "updateRuntimeShadowNodeReferencesOnCommit");
flagValue = currentProvider_->updateRuntimeShadowNodeReferencesOnCommit();
updateRuntimeShadowNodeReferencesOnCommit_ = flagValue;
@@ -1442,7 +1424,7 @@ bool ReactNativeFeatureFlagsAccessor::updateRuntimeShadowNodeReferencesOnCommitT
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(78, "updateRuntimeShadowNodeReferencesOnCommitThread");
markFlagAsAccessed(77, "updateRuntimeShadowNodeReferencesOnCommitThread");
flagValue = currentProvider_->updateRuntimeShadowNodeReferencesOnCommitThread();
updateRuntimeShadowNodeReferencesOnCommitThread_ = flagValue;
@@ -1460,7 +1442,7 @@ bool ReactNativeFeatureFlagsAccessor::useAlwaysAvailableJSErrorHandling() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(79, "useAlwaysAvailableJSErrorHandling");
markFlagAsAccessed(78, "useAlwaysAvailableJSErrorHandling");
flagValue = currentProvider_->useAlwaysAvailableJSErrorHandling();
useAlwaysAvailableJSErrorHandling_ = flagValue;
@@ -1478,7 +1460,7 @@ bool ReactNativeFeatureFlagsAccessor::useFabricInterop() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(80, "useFabricInterop");
markFlagAsAccessed(79, "useFabricInterop");
flagValue = currentProvider_->useFabricInterop();
useFabricInterop_ = flagValue;
@@ -1496,7 +1478,7 @@ bool ReactNativeFeatureFlagsAccessor::useLISAlgorithmInDifferentiator() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(81, "useLISAlgorithmInDifferentiator");
markFlagAsAccessed(80, "useLISAlgorithmInDifferentiator");
flagValue = currentProvider_->useLISAlgorithmInDifferentiator();
useLISAlgorithmInDifferentiator_ = flagValue;
@@ -1514,7 +1496,7 @@ bool ReactNativeFeatureFlagsAccessor::useNativeViewConfigsInBridgelessMode() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(82, "useNativeViewConfigsInBridgelessMode");
markFlagAsAccessed(81, "useNativeViewConfigsInBridgelessMode");
flagValue = currentProvider_->useNativeViewConfigsInBridgelessMode();
useNativeViewConfigsInBridgelessMode_ = flagValue;
@@ -1532,7 +1514,7 @@ bool ReactNativeFeatureFlagsAccessor::useNestedScrollViewAndroid() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(83, "useNestedScrollViewAndroid");
markFlagAsAccessed(82, "useNestedScrollViewAndroid");
flagValue = currentProvider_->useNestedScrollViewAndroid();
useNestedScrollViewAndroid_ = flagValue;
@@ -1550,7 +1532,7 @@ bool ReactNativeFeatureFlagsAccessor::useSharedAnimatedBackend() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(84, "useSharedAnimatedBackend");
markFlagAsAccessed(83, "useSharedAnimatedBackend");
flagValue = currentProvider_->useSharedAnimatedBackend();
useSharedAnimatedBackend_ = flagValue;
@@ -1568,7 +1550,7 @@ bool ReactNativeFeatureFlagsAccessor::useTraitHiddenOnAndroid() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(85, "useTraitHiddenOnAndroid");
markFlagAsAccessed(84, "useTraitHiddenOnAndroid");
flagValue = currentProvider_->useTraitHiddenOnAndroid();
useTraitHiddenOnAndroid_ = flagValue;
@@ -1586,7 +1568,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModuleInterop() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(86, "useTurboModuleInterop");
markFlagAsAccessed(85, "useTurboModuleInterop");
flagValue = currentProvider_->useTurboModuleInterop();
useTurboModuleInterop_ = flagValue;
@@ -1604,7 +1586,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModules() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(87, "useTurboModules");
markFlagAsAccessed(86, "useTurboModules");
flagValue = currentProvider_->useTurboModules();
useTurboModules_ = flagValue;
@@ -1622,7 +1604,7 @@ bool ReactNativeFeatureFlagsAccessor::useUnorderedMapInDifferentiator() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(88, "useUnorderedMapInDifferentiator");
markFlagAsAccessed(87, "useUnorderedMapInDifferentiator");
flagValue = currentProvider_->useUnorderedMapInDifferentiator();
useUnorderedMapInDifferentiator_ = flagValue;
@@ -1640,7 +1622,7 @@ double ReactNativeFeatureFlagsAccessor::viewCullingOutsetRatio() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(89, "viewCullingOutsetRatio");
markFlagAsAccessed(88, "viewCullingOutsetRatio");
flagValue = currentProvider_->viewCullingOutsetRatio();
viewCullingOutsetRatio_ = flagValue;
@@ -1658,7 +1640,7 @@ bool ReactNativeFeatureFlagsAccessor::viewTransitionEnabled() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(90, "viewTransitionEnabled");
markFlagAsAccessed(89, "viewTransitionEnabled");
flagValue = currentProvider_->viewTransitionEnabled();
viewTransitionEnabled_ = flagValue;
@@ -1676,7 +1658,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewPrerenderRatio() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(91, "virtualViewPrerenderRatio");
markFlagAsAccessed(90, "virtualViewPrerenderRatio");
flagValue = currentProvider_->virtualViewPrerenderRatio();
virtualViewPrerenderRatio_ = flagValue;
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<a8a4fabae0ec50559568577e6dc35efb>>
* @generated SignedSource<<11a1936e637ed40b79a1aedd02932e7b>>
*/
/**
@@ -107,7 +107,6 @@ class ReactNativeFeatureFlagsAccessor {
bool shouldPressibilityUseW3CPointerEventsForHover();
bool shouldTriggerResponderTransferOnScrollAndroid();
bool skipActivityIdentityAssertionOnHostPause();
bool syncAndroidClipToPaddingWithOverflow();
bool traceTurboModulePromiseRejectionsOnAndroid();
bool updateRuntimeShadowNodeReferencesOnCommit();
bool updateRuntimeShadowNodeReferencesOnCommitThread();
@@ -135,7 +134,7 @@ class ReactNativeFeatureFlagsAccessor {
std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
bool wasOverridden_;
std::array<std::atomic<const char*>, 92> accessedFeatureFlags_;
std::array<std::atomic<const char*>, 91> accessedFeatureFlags_;
std::atomic<std::optional<bool>> commonTestFlag_;
std::atomic<std::optional<bool>> cdpInteractionMetricsEnabled_;
@@ -212,7 +211,6 @@ class ReactNativeFeatureFlagsAccessor {
std::atomic<std::optional<bool>> shouldPressibilityUseW3CPointerEventsForHover_;
std::atomic<std::optional<bool>> shouldTriggerResponderTransferOnScrollAndroid_;
std::atomic<std::optional<bool>> skipActivityIdentityAssertionOnHostPause_;
std::atomic<std::optional<bool>> syncAndroidClipToPaddingWithOverflow_;
std::atomic<std::optional<bool>> traceTurboModulePromiseRejectionsOnAndroid_;
std::atomic<std::optional<bool>> updateRuntimeShadowNodeReferencesOnCommit_;
std::atomic<std::optional<bool>> updateRuntimeShadowNodeReferencesOnCommitThread_;
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<f6932d0a9c4afcb1b00eb1feba80c823>>
* @generated SignedSource<<6aa42056b9acfeb38e3ea612b6421a15>>
*/
/**
@@ -327,10 +327,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
return false;
}
bool syncAndroidClipToPaddingWithOverflow() override {
return false;
}
bool traceTurboModulePromiseRejectionsOnAndroid() override {
return false;
}
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<84350973e4f2cb0783d0553cffc831f8>>
* @generated SignedSource<<2a4b0d699f7e7e701defd972cd79b116>>
*/
/**
@@ -720,15 +720,6 @@ class ReactNativeFeatureFlagsDynamicProvider : public ReactNativeFeatureFlagsDef
return ReactNativeFeatureFlagsDefaults::skipActivityIdentityAssertionOnHostPause();
}
bool syncAndroidClipToPaddingWithOverflow() override {
auto value = values_["syncAndroidClipToPaddingWithOverflow"];
if (!value.isNull()) {
return value.getBool();
}
return ReactNativeFeatureFlagsDefaults::syncAndroidClipToPaddingWithOverflow();
}
bool traceTurboModulePromiseRejectionsOnAndroid() override {
auto value = values_["traceTurboModulePromiseRejectionsOnAndroid"];
if (!value.isNull()) {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<621857ef3e1c4781a75af981f2fdf2ba>>
* @generated SignedSource<<a383c80abd9321a0376e31171fb5accd>>
*/
/**
@@ -100,7 +100,6 @@ class ReactNativeFeatureFlagsProvider {
virtual bool shouldPressibilityUseW3CPointerEventsForHover() = 0;
virtual bool shouldTriggerResponderTransferOnScrollAndroid() = 0;
virtual bool skipActivityIdentityAssertionOnHostPause() = 0;
virtual bool syncAndroidClipToPaddingWithOverflow() = 0;
virtual bool traceTurboModulePromiseRejectionsOnAndroid() = 0;
virtual bool updateRuntimeShadowNodeReferencesOnCommit() = 0;
virtual bool updateRuntimeShadowNodeReferencesOnCommitThread() = 0;
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<5b2d4d0d38a1dd82815af31c2e8b2063>>
* @generated SignedSource<<4b821513e808ca071104f413e15c2fd9>>
*/
/**
@@ -419,11 +419,6 @@ bool NativeReactNativeFeatureFlags::skipActivityIdentityAssertionOnHostPause(
return ReactNativeFeatureFlags::skipActivityIdentityAssertionOnHostPause();
}
bool NativeReactNativeFeatureFlags::syncAndroidClipToPaddingWithOverflow(
jsi::Runtime& /*runtime*/) {
return ReactNativeFeatureFlags::syncAndroidClipToPaddingWithOverflow();
}
bool NativeReactNativeFeatureFlags::traceTurboModulePromiseRejectionsOnAndroid(
jsi::Runtime& /*runtime*/) {
return ReactNativeFeatureFlags::traceTurboModulePromiseRejectionsOnAndroid();
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<877387fd0971e2e6c4ed81ec60ce3f2b>>
* @generated SignedSource<<55da460bc2f8c915552eeae11f0b2e3e>>
*/
/**
@@ -186,8 +186,6 @@ class NativeReactNativeFeatureFlags
bool skipActivityIdentityAssertionOnHostPause(jsi::Runtime& runtime);
bool syncAndroidClipToPaddingWithOverflow(jsi::Runtime& runtime);
bool traceTurboModulePromiseRejectionsOnAndroid(jsi::Runtime& runtime);
bool updateRuntimeShadowNodeReferencesOnCommit(jsi::Runtime& runtime);
@@ -850,16 +850,6 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
syncAndroidClipToPaddingWithOverflow: {
defaultValue: false,
metadata: {
description:
'Sync clipToPadding on Android views with the overflow property',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
traceTurboModulePromiseRejectionsOnAndroid: {
defaultValue: false,
metadata: {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<615cabb1e51b7bf29c58e68141e603e3>>
* @generated SignedSource<<1d648095164f22868bbdf3500668bb14>>
* @flow strict
* @noformat
*/
@@ -122,7 +122,6 @@ export type ReactNativeFeatureFlags = $ReadOnly<{
shouldPressibilityUseW3CPointerEventsForHover: Getter<boolean>,
shouldTriggerResponderTransferOnScrollAndroid: Getter<boolean>,
skipActivityIdentityAssertionOnHostPause: Getter<boolean>,
syncAndroidClipToPaddingWithOverflow: Getter<boolean>,
traceTurboModulePromiseRejectionsOnAndroid: Getter<boolean>,
updateRuntimeShadowNodeReferencesOnCommit: Getter<boolean>,
updateRuntimeShadowNodeReferencesOnCommitThread: Getter<boolean>,
@@ -505,10 +504,6 @@ export const shouldTriggerResponderTransferOnScrollAndroid: Getter<boolean> = cr
* Skip activity identity assertion in ReactHostImpl::onHostPause()
*/
export const skipActivityIdentityAssertionOnHostPause: Getter<boolean> = createNativeFlagGetter('skipActivityIdentityAssertionOnHostPause', false);
/**
* Sync clipToPadding on Android views with the overflow property
*/
export const syncAndroidClipToPaddingWithOverflow: Getter<boolean> = createNativeFlagGetter('syncAndroidClipToPaddingWithOverflow', false);
/**
* Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
*/
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<af90304d252d40df52756ab27d5523f7>>
* @generated SignedSource<<5dea8e41a09f4ed658ce248121a2e981>>
* @flow strict
* @noformat
*/
@@ -100,7 +100,6 @@ export interface Spec extends TurboModule {
+shouldPressibilityUseW3CPointerEventsForHover?: () => boolean;
+shouldTriggerResponderTransferOnScrollAndroid?: () => boolean;
+skipActivityIdentityAssertionOnHostPause?: () => boolean;
+syncAndroidClipToPaddingWithOverflow?: () => boolean;
+traceTurboModulePromiseRejectionsOnAndroid?: () => boolean;
+updateRuntimeShadowNodeReferencesOnCommit?: () => boolean;
+updateRuntimeShadowNodeReferencesOnCommitThread?: () => boolean;