mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Correctly propagate prepareToRecycleView return value (#49858)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49858 `prepareToRecycleView` returns nullable, since we may decide a view is not recyclable. We should respect that and return the view returned by super. Changelog: [Internal] bypass-github-export-checks Reviewed By: fabriziocucci Differential Revision: D70696246 fbshipit-source-id: a8e12320611a3b6a3d05353e4b7556c4da416aea
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ab9f501c24
commit
c08e16afee
+1
-1
@@ -74,7 +74,7 @@ public class ReactTextViewManager
|
||||
// Defaults from ReactTextAnchorViewManager
|
||||
setSelectionColor(preparedView, null);
|
||||
}
|
||||
return view;
|
||||
return preparedView;
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
+2
-2
@@ -72,11 +72,11 @@ public open class ReactViewManager : ReactClippingViewManager<ReactViewGroup>()
|
||||
override fun prepareToRecycleView(
|
||||
reactContext: ThemedReactContext,
|
||||
view: ReactViewGroup
|
||||
): ReactViewGroup {
|
||||
): ReactViewGroup? {
|
||||
// BaseViewManager
|
||||
val preparedView = super.prepareToRecycleView(reactContext, view)
|
||||
preparedView?.recycleView()
|
||||
return view
|
||||
return preparedView
|
||||
}
|
||||
|
||||
@ReactProp(name = "accessible")
|
||||
|
||||
Reference in New Issue
Block a user