Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BundleDownloader.java (#50065)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50065

Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D71126388

fbshipit-source-id: a9f08b4ce101202cebe13107cc9c6a660deaf58f
This commit is contained in:
Gijs Weterings
2025-03-18 06:08:17 -07:00
committed by Facebook GitHub Bot
parent e9e4c2adaf
commit bdfa0085b7
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BundleDownloader.java
+6
View File
@@ -141,8 +141,10 @@ public class BundleDownloader {
// Make sure the result is a multipart response and parse the boundary.
String contentType = response.header("content-type");
Pattern regex = Pattern.compile("multipart/mixed;.*boundary=\"([^\"]+)\"");
// NULLSAFE_FIXME[Parameter Not Nullable]
Matcher match = regex.matcher(contentType);
if (match.find()) {
// NULLSAFE_FIXME[Parameter Not Nullable]
processMultipartResponse(url, r, match.group(1), outputFile, bundleInfo, callback);
} else {
// In case the server doesn't support multipart/mixed responses, fallback to normal
@@ -152,8 +154,10 @@ public class BundleDownloader {
url,
r.code(),
r.headers(),
// NULLSAFE_FIXME[Nullable Dereference]
r.body().source(),
outputFile,
// NULLSAFE_FIXME[Parameter Not Nullable]
bundleInfo,
callback);
}
@@ -173,6 +177,7 @@ public class BundleDownloader {
throws IOException {
MultipartStreamReader bodyReader =
// NULLSAFE_FIXME[Nullable Dereference]
new MultipartStreamReader(response.body().source(), boundary);
boolean completed =
bodyReader.readAllParts(
@@ -192,6 +197,7 @@ public class BundleDownloader {
status = Integer.parseInt(headers.get("X-Http-Status"));
}
processBundleResult(
// NULLSAFE_FIXME[Parameter Not Nullable]
url, status, Headers.of(headers), body, outputFile, bundleInfo, callback);
} else {
if (!headers.containsKey("Content-Type")