mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Remove dead RAMBundleRegistry::multipleBundlesRegistry static factory
Summary: X-link: https://github.com/facebook/react-native/pull/57137 `RAMBundleRegistry::multipleBundlesRegistry` was a static factory wrapping the public `RAMBundleRegistry` constructor (the one taking a main bundle plus a factory callback), but it had no callers anywhere. Registries are constructed via the public constructor directly. With the sibling `singleBundleRegistry` already removed, this deletes the last orphaned static factory; the constructor and the rest of the class remain intact. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D108012906 fbshipit-source-id: 7bb403ff7660317f0f5b422dca140ac69e048dac
This commit is contained in:
1 parent
b4de836f57
commit
bc7c757e9d
8 files changed
-17
No files matched your search
@@ -20,13 +20,6 @@ namespace facebook::react {
|
||||
constexpr uint32_t RAMBundleRegistry::MAIN_BUNDLE_ID;
|
||||
#pragma clang diagnostic pop
|
||||
|
||||
std::unique_ptr<RAMBundleRegistry> RAMBundleRegistry::multipleBundlesRegistry(
|
||||
std::unique_ptr<JSModulesUnbundle> mainBundle,
|
||||
std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory) {
|
||||
return std::make_unique<RAMBundleRegistry>(
|
||||
std::move(mainBundle), std::move(factory));
|
||||
}
|
||||
|
||||
RAMBundleRegistry::RAMBundleRegistry(
|
||||
std::unique_ptr<JSModulesUnbundle> mainBundle,
|
||||
std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory)
|
||||
|
||||
@@ -27,10 +27,6 @@ class RN_EXPORT [[deprecated("This API will be removed along with the legacy arc
|
||||
public:
|
||||
constexpr static uint32_t MAIN_BUNDLE_ID = 0;
|
||||
|
||||
static std::unique_ptr<RAMBundleRegistry> multipleBundlesRegistry(
|
||||
std::unique_ptr<JSModulesUnbundle> mainBundle,
|
||||
std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory);
|
||||
|
||||
explicit RAMBundleRegistry(
|
||||
std::unique_ptr<JSModulesUnbundle> mainBundle,
|
||||
std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory = nullptr);
|
||||
|
||||
@@ -4179,7 +4179,6 @@ class facebook::react::RAMBundleRegistry {
|
||||
public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
|
||||
public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
|
||||
public static constexpr uint32_t MAIN_BUNDLE_ID;
|
||||
public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
|
||||
public virtual ~RAMBundleRegistry() = default;
|
||||
public void registerBundle(uint32_t bundleId, std::string bundlePath);
|
||||
}
|
||||
|
||||
@@ -4176,7 +4176,6 @@ class facebook::react::RAMBundleRegistry {
|
||||
public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
|
||||
public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
|
||||
public static constexpr uint32_t MAIN_BUNDLE_ID;
|
||||
public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
|
||||
public virtual ~RAMBundleRegistry() = default;
|
||||
public void registerBundle(uint32_t bundleId, std::string bundlePath);
|
||||
}
|
||||
|
||||
@@ -6360,7 +6360,6 @@ class facebook::react::RAMBundleRegistry {
|
||||
public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
|
||||
public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
|
||||
public static constexpr uint32_t MAIN_BUNDLE_ID;
|
||||
public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
|
||||
public virtual ~RAMBundleRegistry() = default;
|
||||
public void registerBundle(uint32_t bundleId, std::string bundlePath);
|
||||
}
|
||||
|
||||
@@ -6357,7 +6357,6 @@ class facebook::react::RAMBundleRegistry {
|
||||
public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
|
||||
public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
|
||||
public static constexpr uint32_t MAIN_BUNDLE_ID;
|
||||
public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
|
||||
public virtual ~RAMBundleRegistry() = default;
|
||||
public void registerBundle(uint32_t bundleId, std::string bundlePath);
|
||||
}
|
||||
|
||||
@@ -2760,7 +2760,6 @@ class facebook::react::RAMBundleRegistry {
|
||||
public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
|
||||
public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
|
||||
public static constexpr uint32_t MAIN_BUNDLE_ID;
|
||||
public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
|
||||
public virtual ~RAMBundleRegistry() = default;
|
||||
public void registerBundle(uint32_t bundleId, std::string bundlePath);
|
||||
}
|
||||
|
||||
@@ -2757,7 +2757,6 @@ class facebook::react::RAMBundleRegistry {
|
||||
public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
|
||||
public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
|
||||
public static constexpr uint32_t MAIN_BUNDLE_ID;
|
||||
public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
|
||||
public virtual ~RAMBundleRegistry() = default;
|
||||
public void registerBundle(uint32_t bundleId, std::string bundlePath);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user