Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove const_cast in createSnapshotFromFile wrapper.

Browse Source 
Summary:
The function is not annotated with `const` so `plain()` will return a non-const
reference to the undecorated Runtime already.  Seems like the const_cast was a
hold-over from a previous iteration.

Reviewed By: mhorowitz

Differential Revision: D16016320

fbshipit-source-id: 3dfa1e9acf2fc5c1ad61c9a8cd27c3c2e42036d3
This commit is contained in:
Ashok Menon
2019-06-27 10:02:26 -07:00
committed by Facebook Github Bot
parent 615902eb78
commit bbf093a03b
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/jsi/jsi/decorator.h
+1 -2
View File
@@ -334,8 +334,7 @@ class RuntimeDecorator : public Base, private jsi::Instrumentation {
}
bool createSnapshotToFile(const std::string& path, bool compact) override {
return const_cast<Plain&>(plain()).instrumentation().createSnapshotToFile(
path, compact);
return plain().instrumentation().createSnapshotToFile(path, compact);
}
void writeBridgeTrafficTraceToFile(