[LOCAL] bypass tag check in dry run (#35428)

This commit is contained in:
Riccardo
2022-11-22 15:02:21 +00:00
committed by GitHub
parent 6107793fda
commit ba1a9defbb
3 changed files with 15 additions and 9 deletions
+1 -1
View File
@@ -76,7 +76,7 @@ async function main() {
);
const token = argv.token;
const releaseVersion = argv.toVersion;
failIfTagExists(releaseVersion);
failIfTagExists(releaseVersion, 'release');
const {pushed} = await inquirer.prompt({
type: 'confirm',
+7 -7
View File
@@ -50,7 +50,13 @@ const releaseVersion = argv.toVersion;
const isLatest = argv.latest;
const isDryRun = argv.dryRun;
failIfTagExists(releaseVersion);
const buildType = isDryRun
? 'dry-run'
: isReleaseBranch(branch)
? 'release'
: 'nightly';
failIfTagExists(releaseVersion, buildType);
if (branch && !isReleaseBranch(branch) && !isDryRun) {
console.error(`This needs to be on a release branch. On branch: ${branch}`);
@@ -60,12 +66,6 @@ if (branch && !isReleaseBranch(branch) && !isDryRun) {
exit(1);
}
const buildType = isDryRun
? 'dry-run'
: isReleaseBranch(branch)
? 'release'
: 'nightly';
const {version} = parseVersion(releaseVersion, buildType);
if (version == null) {
console.error(`Invalid version provided: ${releaseVersion}`);
+7 -1
View File
@@ -137,7 +137,13 @@ function generateiOSArtifacts(
return tarballOutputPath;
}
function failIfTagExists(version) {
function failIfTagExists(version, buildType) {
// When dry-run in stable branch, the tag already exists.
// We are bypassing the tag-existence check when in a dry-run to have the CI pass
if (buildType === 'dry-run') {
return;
}
if (checkIfTagExists(version)) {
echo(`Tag v${version} already exists.`);
echo('You may want to rollback the last commit');