Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Micro-optimization in ReadableNativeMaps

Browse Source 
Summary:
This is just a micro-optimization in ReadableNativeMaps. It wont change much in perf..

changelog: [internal]

Reviewed By: JoshuaGross

Differential Revision: D25733948

fbshipit-source-id: b01109acdf5b2eb532801469ef5cb845010c6ed0
This commit is contained in:
David Vacca
2021-01-01 15:45:06 -08:00
committed by Facebook GitHub Bot
parent 4984c1e525
commit b9ad5a706d
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.cpp
+7 -6
View File
@@ -64,14 +64,15 @@ local_ref<JArrayClass<jstring>> ReadableNativeMap::importKeys() {
return JArrayClass<jstring>::newArray(0);
}
auto pairs = map_.items();
for (auto &pair : pairs) {
keys_.value().push_back(pair.first.asString());
}
jint size = keys_.value().size();
jint size = map_.size();
auto jarray = JArrayClass<jstring>::newArray(size);
for (jint ii = 0; ii < size; ii++) {
(*jarray)[ii] = make_jstring(keys_.value()[ii].getString());
jint i = 0;
for (auto &pair : pairs) {
auto value = pair.first.asString();
keys_.value().push_back(value);
(*jarray)[i++] = make_jstring(value);
}
return jarray;
}