Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Removing checks for oldProps object in [ComponentView updateProps:oldProps:]

Browse Source 
Summary: It's a antient left over which was copy pasted a dozen of times. All `RCTViewComponentView` subclasses have own copy of the old props `_props`, so it's useless to check for `oldProps`.

Reviewed By: mdvacca

Differential Revision: D15770067

fbshipit-source-id: 39f4d71ccdcf0c9a5b911b17a3b922dbe6dd9a8e
This commit is contained in:
Valentin Shergin
2019-06-12 21:18:56 -07:00
committed by Facebook Github Bot
parent dbbdf72248
commit b8bc40e2f0
8 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm
+1 -1
View File
@@ -60,7 +60,7 @@ static UIActivityIndicatorViewStyle convertActivityIndicatorViewStyle(const Acti
- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
{
const auto &oldViewProps = *std::static_pointer_cast<const ActivityIndicatorViewProps>(oldProps ?: _props);
const auto &oldViewProps = *std::static_pointer_cast<const ActivityIndicatorViewProps>(_props);
const auto &newViewProps = *std::static_pointer_cast<const ActivityIndicatorViewProps>(props);
[super updateProps:props oldProps:oldProps];
React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm
+1 -1
View File
@@ -52,7 +52,7 @@
- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
{
const auto &oldImageProps = *std::static_pointer_cast<const ImageProps>(oldProps ?: _props);
const auto &oldImageProps = *std::static_pointer_cast<const ImageProps>(_props);
const auto &newImageProps = *std::static_pointer_cast<const ImageProps>(props);
[super updateProps:props oldProps:oldProps];
React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
+1 -1
View File
@@ -71,7 +71,7 @@ using namespace facebook::react;
- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
{
const auto &oldScrollViewProps = *std::static_pointer_cast<const ScrollViewProps>(oldProps ?: _props);
const auto &oldScrollViewProps = *std::static_pointer_cast<const ScrollViewProps>(_props);
const auto &newScrollViewProps = *std::static_pointer_cast<const ScrollViewProps>(props);
[super updateProps:props oldProps:oldProps];
React/Fabric/Mounting/ComponentViews/ScrollView/RNPullToRefreshViewComponentView.mm
+1 -1
View File
@@ -50,7 +50,7 @@ using namespace facebook::react;
- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
{
auto const &oldConcreteProps = *std::static_pointer_cast<PullToRefreshViewProps const>(oldProps ?: _props);
auto const &oldConcreteProps = *std::static_pointer_cast<PullToRefreshViewProps const>(_props);
auto const &newConcreteProps = *std::static_pointer_cast<PullToRefreshViewProps const>(props);
[super updateProps:props oldProps:oldProps];
React/Fabric/Mounting/ComponentViews/Slider/RCTSliderComponentView.mm
+1 -1
View File
@@ -109,7 +109,7 @@ using namespace facebook::react;
- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
{
const auto &oldSliderProps = *std::static_pointer_cast<const SliderProps>(oldProps ?: _props);
const auto &oldSliderProps = *std::static_pointer_cast<const SliderProps>(_props);
const auto &newSliderProps = *std::static_pointer_cast<const SliderProps>(props);
[super updateProps:props oldProps:oldProps];
React/Fabric/Mounting/ComponentViews/Switch/RCTSwitchComponentView.mm
+1 -1
View File
@@ -45,7 +45,7 @@ using namespace facebook::react;
- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
{
const auto &oldSwitchProps = *std::static_pointer_cast<const SwitchProps>(oldProps ?: _props);
const auto &oldSwitchProps = *std::static_pointer_cast<const SwitchProps>(_props);
const auto &newSwitchProps = *std::static_pointer_cast<const SwitchProps>(props);
[super updateProps:props oldProps:oldProps];
React/Fabric/Mounting/ComponentViews/UnimplementedComponent/RCTUnimplementedNativeComponentView.mm
+1 -1
View File
@@ -47,7 +47,7 @@ using namespace facebook::react;
- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
{
const auto &oldViewProps = *std::static_pointer_cast<const UnimplementedNativeViewProps>(oldProps ?: _props);
const auto &oldViewProps = *std::static_pointer_cast<const UnimplementedNativeViewProps>(_props);
const auto &newViewProps = *std::static_pointer_cast<const UnimplementedNativeViewProps>(props);
[super updateProps:props oldProps:oldProps];
React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
+1 -1
View File
@@ -107,7 +107,7 @@ using namespace facebook::react;
NSStringFromClass([self class]));
#endif
auto const &oldViewProps = *std::static_pointer_cast<ViewProps const>(oldProps ?: _props);
auto const &oldViewProps = *std::static_pointer_cast<ViewProps const>(_props);
auto const &newViewProps = *std::static_pointer_cast<ViewProps const>(props);
_props = std::static_pointer_cast<ViewProps const>(props);