mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix retain cycle in RCTFabricSurface
Summary: Changelog: [internal] Fix retain cycle caused by chain: `RCTSurfaceTouchHandler` -> `RCTSurfaceTouchHandler._rootComponentView` -> `RCTSurfaceTouchHandler` `RCTSurfaceTouchHandler._rootComponentView` calls `addGestureRecognizer` with `RCTSurfaceTouchHandler` as a parameter which, according to documentation, strongly holds onto gesture recogniser. https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/js/react-native-github/React/Fabric/RCTSurfaceTouchHandler.mm?lines=189 For details about `addGestureRecognizer`, refer to https://developer.apple.com/documentation/appkit/nsview/1483749-addgesturerecognizer?language=objc# Reviewed By: shergin Differential Revision: D23704441 fbshipit-source-id: b1ab0feff552eaf10c1c71a931690c5258ce87cf
This commit is contained in:
1 parent
635ac1ba53
commit
b705eafd22
1 file changed
+1
@@ -83,6 +83,7 @@ using namespace facebook::react;
|
||||
}
|
||||
|
||||
[_surfacePresenter unregisterSurface:self];
|
||||
[_touchHandler detachFromView:_view];
|
||||
return YES;
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user