mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix Android JSC compatibility - replaceAll -> replace (#48076)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48076 JSC for Android does not implement `String.prototype.replaceAll`: {F1971791988} https://github.com/facebook/react-native/pull/47466 introduced a use of it into runtime code, breaking JSC compatibility. This.. replaces it.. with `replace`. Since the argument is already a regex with a `g` modifier, `replaceAll` wasn't necessary anyway. Changelog: [ANDROID][FIXED] Fix JSC by avoiding use of unavailable `str.replaceAll()` Reviewed By: javache Differential Revision: D66712312 fbshipit-source-id: 534b6db6834a2fda46ae8457437de3caa24f4eb0
This commit is contained in:
committed by
Facebook GitHub Bot
parent
4c62d46525
commit
b5b9e032c2
@@ -559,7 +559,7 @@ if (global.nativeLoggingHook) {
|
||||
let originalConsoleError = console.error;
|
||||
console.reportErrorsAsExceptions = true;
|
||||
function stringifySafe(arg) {
|
||||
return inspect(arg, {depth: 10}).replaceAll(/\n\s*/g, ' ');
|
||||
return inspect(arg, {depth: 10}).replace(/\n\s*/g, ' ');
|
||||
}
|
||||
console.error = function (...args) {
|
||||
originalConsoleError.apply(this, args);
|
||||
|
||||
Reference in New Issue
Block a user