Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use preprocessor flags to set CREATE_SHARED_LIBRARY instead of mode file

Browse Source 
Summary: Changelog: [Internal]

Reviewed By: MartinSherburn

Differential Revision: D37600540

fbshipit-source-id: 40cf30ec2960864fc862c31661b1308c57f33bec
This commit is contained in:
Pieter De Baets
2022-07-08 08:41:05 -07:00
committed by Facebook GitHub Bot
parent 468b86bd37
commit b4e6a786b7
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/hermes/inspector/BUCK
+2 -1
View File
@@ -2,7 +2,7 @@ load("@fbsource//tools/build_defs:fb_xplat_cxx_binary.bzl", "fb_xplat_cxx_binary
load("@fbsource//tools/build_defs:fb_xplat_cxx_library.bzl", "fb_xplat_cxx_library")
load("@fbsource//tools/build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test")
load("@fbsource//tools/build_defs:platform_defs.bzl", "ANDROID", "APPLE", "CXX", "FBCODE", "WINDOWS")
load("@fbsource//tools/build_defs/oss:rn_defs.bzl", "react_native_xplat_target")
load("@fbsource//tools/build_defs/oss:rn_defs.bzl", "get_hermes_shared_library_preprocessor_flags", "react_native_xplat_target")
load("@fbsource//xplat/hermes/defs:hermes.bzl", "hermes_build_mode", "hermes_optimize_flag")
CFLAGS_BY_MODE = {
@@ -195,6 +195,7 @@ fb_xplat_cxx_library(
labels = ["supermodule:xplat/default/public.hermes"],
macosx_tests_override = [],
platforms = (ANDROID, APPLE, CXX, FBCODE, WINDOWS),
preprocessor_flags = get_hermes_shared_library_preprocessor_flags(),
visibility = [
"PUBLIC",
],
ReactCommon/jsinspector/BUCK
+2 -1
View File
@@ -1,6 +1,6 @@
load("@fbsource//tools/build_defs:glob_defs.bzl", "subdir_glob")
load("@fbsource//tools/build_defs:platform_defs.bzl", "ANDROID", "APPLE", "CXX", "FBCODE", "WINDOWS")
load("//tools/build_defs/oss:rn_defs.bzl", "rn_xplat_cxx_library")
load("//tools/build_defs/oss:rn_defs.bzl", "get_hermes_shared_library_preprocessor_flags", "rn_xplat_cxx_library")
EXPORTED_HEADERS = [
"InspectorInterfaces.h",
@@ -32,6 +32,7 @@ rn_xplat_cxx_library(
"supermodule:xplat/default/public.react_native.infra",
],
platforms = (ANDROID, APPLE, CXX, FBCODE, WINDOWS),
preprocessor_flags = get_hermes_shared_library_preprocessor_flags(),
visibility = [
"PUBLIC",
],
tools/build_defs/oss/rn_defs.bzl
+3
View File
@@ -36,6 +36,9 @@ def get_objc_arc_preprocessor_flags():
"-Qunused-arguments",
]
def get_hermes_shared_library_preprocessor_flags():
return []
IS_OSS_BUILD = True
GLOG_DEP = "//ReactAndroid/build/third-party-ndk/glog:glog"