mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
delete feature flag enableCustomDrawOrderFabric (#44231)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44231 changelog: [internal] The flag is not used and is statically set to false, let's delete it. Reviewed By: NickGerleman Differential Revision: D56473851 fbshipit-source-id: fe1076d20a765ffed2437f080764f2b5fe060bb6
This commit is contained in:
committed by
Facebook GitHub Bot
parent
0dbe6f10c1
commit
b40b3b31a2
+1
-7
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<4adf12f2d6a102944b0fa922aa1c3e84>>
|
||||
* @generated SignedSource<<9eadcbd838fd9cda33485db003c23f15>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -64,12 +64,6 @@ public object ReactNativeFeatureFlags {
|
||||
@JvmStatic
|
||||
public fun enableCleanTextInputYogaNode(): Boolean = accessor.enableCleanTextInputYogaNode()
|
||||
|
||||
/**
|
||||
* When enabled, Fabric will use customDrawOrder in ReactViewGroup (similar to old architecture).
|
||||
*/
|
||||
@JvmStatic
|
||||
public fun enableCustomDrawOrderFabric(): Boolean = accessor.enableCustomDrawOrderFabric()
|
||||
|
||||
/**
|
||||
* Enables the use of microtasks in Hermes (scheduling) and RuntimeScheduler (execution).
|
||||
*/
|
||||
|
||||
+1
-11
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<24c24962f08ba7c52c296a5ac9abdbbc>>
|
||||
* @generated SignedSource<<0a9209f5ccc8bb15801c53978f8e8543>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -26,7 +26,6 @@ public class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAccesso
|
||||
private var destroyFabricSurfacesInReactInstanceManagerCache: Boolean? = null
|
||||
private var enableBackgroundExecutorCache: Boolean? = null
|
||||
private var enableCleanTextInputYogaNodeCache: Boolean? = null
|
||||
private var enableCustomDrawOrderFabricCache: Boolean? = null
|
||||
private var enableMicrotasksCache: Boolean? = null
|
||||
private var enableSpannableBuildingUnificationCache: Boolean? = null
|
||||
private var enableSynchronousStateUpdatesCache: Boolean? = null
|
||||
@@ -94,15 +93,6 @@ public class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAccesso
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun enableCustomDrawOrderFabric(): Boolean {
|
||||
var cached = enableCustomDrawOrderFabricCache
|
||||
if (cached == null) {
|
||||
cached = ReactNativeFeatureFlagsCxxInterop.enableCustomDrawOrderFabric()
|
||||
enableCustomDrawOrderFabricCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun enableMicrotasks(): Boolean {
|
||||
var cached = enableMicrotasksCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<0ceccc453595057ca96d9ae49c7f4637>>
|
||||
* @generated SignedSource<<3c144393313cb8746474c172c9313a0f>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -40,8 +40,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun enableCleanTextInputYogaNode(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun enableCustomDrawOrderFabric(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun enableMicrotasks(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun enableSpannableBuildingUnification(): Boolean
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<29720cb2aa02ebdbe8e5efbe9e3a4b01>>
|
||||
* @generated SignedSource<<201a7ad4db3884cb51719684c4279d58>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -35,8 +35,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun enableCleanTextInputYogaNode(): Boolean = false
|
||||
|
||||
override fun enableCustomDrawOrderFabric(): Boolean = false
|
||||
|
||||
override fun enableMicrotasks(): Boolean = false
|
||||
|
||||
override fun enableSpannableBuildingUnification(): Boolean = false
|
||||
|
||||
+1
-12
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<977c8d88557a37c750ec59e67c94878c>>
|
||||
* @generated SignedSource<<a5880a25b1c555713b7bf55e61a39a3d>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -30,7 +30,6 @@ public class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcces
|
||||
private var destroyFabricSurfacesInReactInstanceManagerCache: Boolean? = null
|
||||
private var enableBackgroundExecutorCache: Boolean? = null
|
||||
private var enableCleanTextInputYogaNodeCache: Boolean? = null
|
||||
private var enableCustomDrawOrderFabricCache: Boolean? = null
|
||||
private var enableMicrotasksCache: Boolean? = null
|
||||
private var enableSpannableBuildingUnificationCache: Boolean? = null
|
||||
private var enableSynchronousStateUpdatesCache: Boolean? = null
|
||||
@@ -104,16 +103,6 @@ public class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcces
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun enableCustomDrawOrderFabric(): Boolean {
|
||||
var cached = enableCustomDrawOrderFabricCache
|
||||
if (cached == null) {
|
||||
cached = currentProvider.enableCustomDrawOrderFabric()
|
||||
accessedFeatureFlags.add("enableCustomDrawOrderFabric")
|
||||
enableCustomDrawOrderFabricCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun enableMicrotasks(): Boolean {
|
||||
var cached = enableMicrotasksCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<a76816db2d7d7d3f0463103387e2a049>>
|
||||
* @generated SignedSource<<5594e9b51122080fbb3cbda8f5367abf>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -35,8 +35,6 @@ public interface ReactNativeFeatureFlagsProvider {
|
||||
|
||||
@DoNotStrip public fun enableCleanTextInputYogaNode(): Boolean
|
||||
|
||||
@DoNotStrip public fun enableCustomDrawOrderFabric(): Boolean
|
||||
|
||||
@DoNotStrip public fun enableMicrotasks(): Boolean
|
||||
|
||||
@DoNotStrip public fun enableSpannableBuildingUnification(): Boolean
|
||||
|
||||
+2
-5
@@ -32,7 +32,6 @@ import com.facebook.react.bridge.ReactNoCrashSoftException;
|
||||
import com.facebook.react.bridge.ReactSoftExceptionLogger;
|
||||
import com.facebook.react.bridge.UiThreadUtil;
|
||||
import com.facebook.react.common.annotations.VisibleForTesting;
|
||||
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags;
|
||||
import com.facebook.react.modules.i18nmanager.I18nUtil;
|
||||
import com.facebook.react.touch.OnInterceptTouchEventListener;
|
||||
import com.facebook.react.touch.ReactHitSlopView;
|
||||
@@ -510,11 +509,9 @@ public class ReactViewGroup extends ViewGroup
|
||||
if (getId() == NO_ID) {
|
||||
return false;
|
||||
}
|
||||
if (ViewUtil.getUIManagerType(getId()) != UIManagerType.FABRIC) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return !ReactNativeFeatureFlags.enableCustomDrawOrderFabric();
|
||||
// Custom draw order is disabled for Fabric.
|
||||
return ViewUtil.getUIManagerType(getId()) == UIManagerType.FABRIC;
|
||||
}
|
||||
|
||||
private void handleAddView(View view) {
|
||||
|
||||
+1
-15
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<42365eadf2648e4033ec6be2c387c019>>
|
||||
* @generated SignedSource<<03c9714f0cdb99cbff20ba76b8deac87>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -75,12 +75,6 @@ class ReactNativeFeatureFlagsProviderHolder
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool enableCustomDrawOrderFabric() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("enableCustomDrawOrderFabric");
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool enableMicrotasks() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("enableMicrotasks");
|
||||
@@ -187,11 +181,6 @@ bool JReactNativeFeatureFlagsCxxInterop::enableCleanTextInputYogaNode(
|
||||
return ReactNativeFeatureFlags::enableCleanTextInputYogaNode();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::enableCustomDrawOrderFabric(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::enableCustomDrawOrderFabric();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::enableMicrotasks(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::enableMicrotasks();
|
||||
@@ -287,9 +276,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
|
||||
makeNativeMethod(
|
||||
"enableCleanTextInputYogaNode",
|
||||
JReactNativeFeatureFlagsCxxInterop::enableCleanTextInputYogaNode),
|
||||
makeNativeMethod(
|
||||
"enableCustomDrawOrderFabric",
|
||||
JReactNativeFeatureFlagsCxxInterop::enableCustomDrawOrderFabric),
|
||||
makeNativeMethod(
|
||||
"enableMicrotasks",
|
||||
JReactNativeFeatureFlagsCxxInterop::enableMicrotasks),
|
||||
|
||||
+1
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<dfdbec53de07274b4a95d51d74868686>>
|
||||
* @generated SignedSource<<f6a67c3d3c0b96645c3bd9684132389d>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -48,9 +48,6 @@ class JReactNativeFeatureFlagsCxxInterop
|
||||
static bool enableCleanTextInputYogaNode(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool enableCustomDrawOrderFabric(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool enableMicrotasks(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<43c8603042b627380cb5f6150e670753>>
|
||||
* @generated SignedSource<<fba1c2994faa122b60ee86cdc1ba5b70>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -45,10 +45,6 @@ bool ReactNativeFeatureFlags::enableCleanTextInputYogaNode() {
|
||||
return getAccessor().enableCleanTextInputYogaNode();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::enableCustomDrawOrderFabric() {
|
||||
return getAccessor().enableCustomDrawOrderFabric();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::enableMicrotasks() {
|
||||
return getAccessor().enableMicrotasks();
|
||||
}
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<a5407b903ea2f1d695a948738ecce536>>
|
||||
* @generated SignedSource<<591d73f7e2f424ec872614831a4626ed>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -67,11 +67,6 @@ class ReactNativeFeatureFlags {
|
||||
*/
|
||||
RN_EXPORT static bool enableCleanTextInputYogaNode();
|
||||
|
||||
/**
|
||||
* When enabled, Fabric will use customDrawOrder in ReactViewGroup (similar to old architecture).
|
||||
*/
|
||||
RN_EXPORT static bool enableCustomDrawOrderFabric();
|
||||
|
||||
/**
|
||||
* Enables the use of microtasks in Hermes (scheduling) and RuntimeScheduler (execution).
|
||||
*/
|
||||
|
||||
+13
-31
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<0f4b93e6084d0e386563d685cc2bc419>>
|
||||
* @generated SignedSource<<527421522f31923d59f90278ef457221>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -137,24 +137,6 @@ bool ReactNativeFeatureFlagsAccessor::enableCleanTextInputYogaNode() {
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::enableCustomDrawOrderFabric() {
|
||||
auto flagValue = enableCustomDrawOrderFabric_.load();
|
||||
|
||||
if (!flagValue.has_value()) {
|
||||
// This block is not exclusive but it is not necessary.
|
||||
// If multiple threads try to initialize the feature flag, we would only
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(6, "enableCustomDrawOrderFabric");
|
||||
|
||||
flagValue = currentProvider_->enableCustomDrawOrderFabric();
|
||||
enableCustomDrawOrderFabric_ = flagValue;
|
||||
}
|
||||
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::enableMicrotasks() {
|
||||
auto flagValue = enableMicrotasks_.load();
|
||||
|
||||
@@ -164,7 +146,7 @@ bool ReactNativeFeatureFlagsAccessor::enableMicrotasks() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(7, "enableMicrotasks");
|
||||
markFlagAsAccessed(6, "enableMicrotasks");
|
||||
|
||||
flagValue = currentProvider_->enableMicrotasks();
|
||||
enableMicrotasks_ = flagValue;
|
||||
@@ -182,7 +164,7 @@ bool ReactNativeFeatureFlagsAccessor::enableSpannableBuildingUnification() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(8, "enableSpannableBuildingUnification");
|
||||
markFlagAsAccessed(7, "enableSpannableBuildingUnification");
|
||||
|
||||
flagValue = currentProvider_->enableSpannableBuildingUnification();
|
||||
enableSpannableBuildingUnification_ = flagValue;
|
||||
@@ -200,7 +182,7 @@ bool ReactNativeFeatureFlagsAccessor::enableSynchronousStateUpdates() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(9, "enableSynchronousStateUpdates");
|
||||
markFlagAsAccessed(8, "enableSynchronousStateUpdates");
|
||||
|
||||
flagValue = currentProvider_->enableSynchronousStateUpdates();
|
||||
enableSynchronousStateUpdates_ = flagValue;
|
||||
@@ -218,7 +200,7 @@ bool ReactNativeFeatureFlagsAccessor::enableUIConsistency() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(10, "enableUIConsistency");
|
||||
markFlagAsAccessed(9, "enableUIConsistency");
|
||||
|
||||
flagValue = currentProvider_->enableUIConsistency();
|
||||
enableUIConsistency_ = flagValue;
|
||||
@@ -236,7 +218,7 @@ bool ReactNativeFeatureFlagsAccessor::fixMountedFlagAndFixPreallocationClone() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(11, "fixMountedFlagAndFixPreallocationClone");
|
||||
markFlagAsAccessed(10, "fixMountedFlagAndFixPreallocationClone");
|
||||
|
||||
flagValue = currentProvider_->fixMountedFlagAndFixPreallocationClone();
|
||||
fixMountedFlagAndFixPreallocationClone_ = flagValue;
|
||||
@@ -254,7 +236,7 @@ bool ReactNativeFeatureFlagsAccessor::forceBatchingMountItemsOnAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(12, "forceBatchingMountItemsOnAndroid");
|
||||
markFlagAsAccessed(11, "forceBatchingMountItemsOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->forceBatchingMountItemsOnAndroid();
|
||||
forceBatchingMountItemsOnAndroid_ = flagValue;
|
||||
@@ -272,7 +254,7 @@ bool ReactNativeFeatureFlagsAccessor::inspectorEnableCxxInspectorPackagerConnect
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(13, "inspectorEnableCxxInspectorPackagerConnection");
|
||||
markFlagAsAccessed(12, "inspectorEnableCxxInspectorPackagerConnection");
|
||||
|
||||
flagValue = currentProvider_->inspectorEnableCxxInspectorPackagerConnection();
|
||||
inspectorEnableCxxInspectorPackagerConnection_ = flagValue;
|
||||
@@ -290,7 +272,7 @@ bool ReactNativeFeatureFlagsAccessor::inspectorEnableModernCDPRegistry() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(14, "inspectorEnableModernCDPRegistry");
|
||||
markFlagAsAccessed(13, "inspectorEnableModernCDPRegistry");
|
||||
|
||||
flagValue = currentProvider_->inspectorEnableModernCDPRegistry();
|
||||
inspectorEnableModernCDPRegistry_ = flagValue;
|
||||
@@ -308,7 +290,7 @@ bool ReactNativeFeatureFlagsAccessor::preventDoubleTextMeasure() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(15, "preventDoubleTextMeasure");
|
||||
markFlagAsAccessed(14, "preventDoubleTextMeasure");
|
||||
|
||||
flagValue = currentProvider_->preventDoubleTextMeasure();
|
||||
preventDoubleTextMeasure_ = flagValue;
|
||||
@@ -326,7 +308,7 @@ bool ReactNativeFeatureFlagsAccessor::useModernRuntimeScheduler() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(16, "useModernRuntimeScheduler");
|
||||
markFlagAsAccessed(15, "useModernRuntimeScheduler");
|
||||
|
||||
flagValue = currentProvider_->useModernRuntimeScheduler();
|
||||
useModernRuntimeScheduler_ = flagValue;
|
||||
@@ -344,7 +326,7 @@ bool ReactNativeFeatureFlagsAccessor::useNativeViewConfigsInBridgelessMode() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(17, "useNativeViewConfigsInBridgelessMode");
|
||||
markFlagAsAccessed(16, "useNativeViewConfigsInBridgelessMode");
|
||||
|
||||
flagValue = currentProvider_->useNativeViewConfigsInBridgelessMode();
|
||||
useNativeViewConfigsInBridgelessMode_ = flagValue;
|
||||
@@ -362,7 +344,7 @@ bool ReactNativeFeatureFlagsAccessor::useStateAlignmentMechanism() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(18, "useStateAlignmentMechanism");
|
||||
markFlagAsAccessed(17, "useStateAlignmentMechanism");
|
||||
|
||||
flagValue = currentProvider_->useStateAlignmentMechanism();
|
||||
useStateAlignmentMechanism_ = flagValue;
|
||||
|
||||
+2
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<b7f8935c2b0e5449088a7613423982a7>>
|
||||
* @generated SignedSource<<811a055d007f6994b21c2e7ce0d79302>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -37,7 +37,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
bool destroyFabricSurfacesInReactInstanceManager();
|
||||
bool enableBackgroundExecutor();
|
||||
bool enableCleanTextInputYogaNode();
|
||||
bool enableCustomDrawOrderFabric();
|
||||
bool enableMicrotasks();
|
||||
bool enableSpannableBuildingUnification();
|
||||
bool enableSynchronousStateUpdates();
|
||||
@@ -60,7 +59,7 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
|
||||
bool wasOverridden_;
|
||||
|
||||
std::array<std::atomic<const char*>, 19> accessedFeatureFlags_;
|
||||
std::array<std::atomic<const char*>, 18> accessedFeatureFlags_;
|
||||
|
||||
std::atomic<std::optional<bool>> commonTestFlag_;
|
||||
std::atomic<std::optional<bool>> androidEnablePendingFabricTransactions_;
|
||||
@@ -68,7 +67,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::atomic<std::optional<bool>> destroyFabricSurfacesInReactInstanceManager_;
|
||||
std::atomic<std::optional<bool>> enableBackgroundExecutor_;
|
||||
std::atomic<std::optional<bool>> enableCleanTextInputYogaNode_;
|
||||
std::atomic<std::optional<bool>> enableCustomDrawOrderFabric_;
|
||||
std::atomic<std::optional<bool>> enableMicrotasks_;
|
||||
std::atomic<std::optional<bool>> enableSpannableBuildingUnification_;
|
||||
std::atomic<std::optional<bool>> enableSynchronousStateUpdates_;
|
||||
|
||||
+1
-5
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<1c1413a29d3a3baf9876d4dfbd18e54f>>
|
||||
* @generated SignedSource<<86a28a4327a46f324102b81050d14214>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -51,10 +51,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool enableCustomDrawOrderFabric() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool enableMicrotasks() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<9e58a6e297303c4637a984628a7ded1c>>
|
||||
* @generated SignedSource<<e664ef56b836fbd100fac0cefbe593eb>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -31,7 +31,6 @@ class ReactNativeFeatureFlagsProvider {
|
||||
virtual bool destroyFabricSurfacesInReactInstanceManager() = 0;
|
||||
virtual bool enableBackgroundExecutor() = 0;
|
||||
virtual bool enableCleanTextInputYogaNode() = 0;
|
||||
virtual bool enableCustomDrawOrderFabric() = 0;
|
||||
virtual bool enableMicrotasks() = 0;
|
||||
virtual bool enableSpannableBuildingUnification() = 0;
|
||||
virtual bool enableSynchronousStateUpdates() = 0;
|
||||
|
||||
+1
-6
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<425a83dc7418db4dcd44deae3b2dd4ce>>
|
||||
* @generated SignedSource<<f4a72a5a53648d8710aa72d8a0879995>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -67,11 +67,6 @@ bool NativeReactNativeFeatureFlags::enableCleanTextInputYogaNode(
|
||||
return ReactNativeFeatureFlags::enableCleanTextInputYogaNode();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::enableCustomDrawOrderFabric(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::enableCustomDrawOrderFabric();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::enableMicrotasks(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::enableMicrotasks();
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<e2c21b57d4a3d8b8b55d37f45cf37df4>>
|
||||
* @generated SignedSource<<2996a4d6acd8b62e6326f587d0a4d448>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -47,8 +47,6 @@ class NativeReactNativeFeatureFlags
|
||||
|
||||
bool enableCleanTextInputYogaNode(jsi::Runtime& runtime);
|
||||
|
||||
bool enableCustomDrawOrderFabric(jsi::Runtime& runtime);
|
||||
|
||||
bool enableMicrotasks(jsi::Runtime& runtime);
|
||||
|
||||
bool enableSpannableBuildingUnification(jsi::Runtime& runtime);
|
||||
|
||||
@@ -56,11 +56,6 @@ const definitions: FeatureFlagDefinitions = {
|
||||
defaultValue: false,
|
||||
description: 'Clean yoga node when <TextInput /> does not change.',
|
||||
},
|
||||
enableCustomDrawOrderFabric: {
|
||||
defaultValue: false,
|
||||
description:
|
||||
'When enabled, Fabric will use customDrawOrder in ReactViewGroup (similar to old architecture).',
|
||||
},
|
||||
enableMicrotasks: {
|
||||
defaultValue: false,
|
||||
description:
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<2069622ac0b7f7a7aa1523d891d2969b>>
|
||||
* @generated SignedSource<<5155e9913578dcfd8313f768974d20fc>>
|
||||
* @flow strict-local
|
||||
*/
|
||||
|
||||
@@ -46,7 +46,6 @@ export type ReactNativeFeatureFlags = {
|
||||
destroyFabricSurfacesInReactInstanceManager: Getter<boolean>,
|
||||
enableBackgroundExecutor: Getter<boolean>,
|
||||
enableCleanTextInputYogaNode: Getter<boolean>,
|
||||
enableCustomDrawOrderFabric: Getter<boolean>,
|
||||
enableMicrotasks: Getter<boolean>,
|
||||
enableSpannableBuildingUnification: Getter<boolean>,
|
||||
enableSynchronousStateUpdates: Getter<boolean>,
|
||||
@@ -125,10 +124,6 @@ export const enableBackgroundExecutor: Getter<boolean> = createNativeFlagGetter(
|
||||
* Clean yoga node when <TextInput /> does not change.
|
||||
*/
|
||||
export const enableCleanTextInputYogaNode: Getter<boolean> = createNativeFlagGetter('enableCleanTextInputYogaNode', false);
|
||||
/**
|
||||
* When enabled, Fabric will use customDrawOrder in ReactViewGroup (similar to old architecture).
|
||||
*/
|
||||
export const enableCustomDrawOrderFabric: Getter<boolean> = createNativeFlagGetter('enableCustomDrawOrderFabric', false);
|
||||
/**
|
||||
* Enables the use of microtasks in Hermes (scheduling) and RuntimeScheduler (execution).
|
||||
*/
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<4dc41ba7453a167d762168aca78ad8c4>>
|
||||
* @generated SignedSource<<2dd0e401cb2ce011c938378bda940c9b>>
|
||||
* @flow strict-local
|
||||
*/
|
||||
|
||||
@@ -29,7 +29,6 @@ export interface Spec extends TurboModule {
|
||||
+destroyFabricSurfacesInReactInstanceManager?: () => boolean;
|
||||
+enableBackgroundExecutor?: () => boolean;
|
||||
+enableCleanTextInputYogaNode?: () => boolean;
|
||||
+enableCustomDrawOrderFabric?: () => boolean;
|
||||
+enableMicrotasks?: () => boolean;
|
||||
+enableSpannableBuildingUnification?: () => boolean;
|
||||
+enableSynchronousStateUpdates?: () => boolean;
|
||||
|
||||
Reference in New Issue
Block a user