Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect Height in Text components

Browse Source 
Summary:
This diff fixes a bug in the calculation of layout for text components

The rootcause of the bug is that fabric is not taking into consideration height constraints as part of the cache for text measurments.
The title text was being measured with a specific height constraint (22px) at the begining of the render, later there was a re-measure for the same Text component with a different height constraint, but fabric was reusing the result of the first calculation instead of re-measuring the text.

changelog: [internal] internal

Reviewed By: JoshuaGross

Differential Revision: D26676716

fbshipit-source-id: 3e769e0ca35b3e363b96d3a6d1626a091eaad908
This commit is contained in:
David Vacca
2021-02-25 17:54:49 -08:00
committed by Facebook GitHub Bot
parent 7b814b467a
commit b3cdf8cd7e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.h
+3 -1
View File
@@ -190,7 +190,9 @@ inline bool operator==(
lhs.attributedString, rhs.attributedString) &&
lhs.paragraphAttributes == rhs.paragraphAttributes &&
lhs.layoutConstraints.maximumSize.width ==
rhs.layoutConstraints.maximumSize.width;
rhs.layoutConstraints.maximumSize.width &&
lhs.layoutConstraints.maximumSize.height ==
rhs.layoutConstraints.maximumSize.height;
}
inline bool operator!=(