removal of textColor from base application theme (#31487)

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Summary:
https://github.com/facebook/react-native/issues/31345

The issue to` android/app/src/main/res/values/styles.xml.`
In the base application theme, there is an explicitly added item
`<item name="android:textColor">#000000</item>`
This leads the `textColor` of the app to be black even though the theme is actually DayNight.
A permanent fix would be to not have this item added by default when creating a new project, as it is buggy behavior

## Changelog

[General] [removed] -  line `<item name="android:textColor">#000000</item>` in this file `android/app/src/main/res/values/styles.xml `for the inital setup

Pull Request resolved: https://github.com/facebook/react-native/pull/31487

Test Plan: Removing this has fixed the issue for me.

Reviewed By: yungsters

Differential Revision: D28966678

Pulled By: ShikaSD

fbshipit-source-id: 57c6b4b7b5f11847ea6e611c7567c0c03133c79d

This commit is contained in:

Siddharth Verma

2021-06-10 00:49:00 -07:00

committed by

Facebook GitHub Bot

parent 9a5e22650a

commit b3a715f6ea

1 changed files with 0 additions and 1 deletions

									
										template/android/app/src/main/res/values/styles.xml
									
		-1
	
												View File
												
				@@ -3,7 +3,6 @@

				    <!-- Base application theme. -->

				    <style name="AppTheme" parent="Theme.AppCompat.DayNight.NoActionBar">

				        <!-- Customize your theme here. -->

				        <item name="android:textColor">#000000</item>

				    </style>

				</resources>