Fix isClickable state after recycling text views (#54682)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/54682

Changelog:
[Android][Fixed] - Fixed recycled TextViews incorrectly appearing as clickable to accessibility systems

When recycling TextViews on Android, calling `setOnClickListener(null)` has the side effect of setting `isClickable=true`.

This caused recycled text views to be incorrectly detected as interactive elements by accessibility systems.

The fix reorders operations in`BaseViewManager.prepareToRecycleView()` to call `setClickable()` *after* `setOnClickListener(null)`, ensuring the correct clickable state is set after the side effect occurs.

Reviewed By: javache

Differential Revision: D87860421

fbshipit-source-id: e770d76e122db1580e4a5342ac887f284036e58b
This commit is contained in:
Fabrizio Cucci authored and meta-codesync[bot] committed 2025-11-25 08:22:58 -08:00
1 parent 4c560b118c
commit b34e9c542d
1 file changed
+6 -4
@@ -148,13 +148,15 @@ public abstract class BaseViewManager<T extends View, C extends LayoutShadowNode
// are the default view flags in View.java:
// https://android.googlesource.com/platform/frameworks/base/+/a175a5b/core/java/android/view/View.java#2712
// `mViewFlags = SOUND_EFFECTS_ENABLED | HAPTIC_FEEDBACK_ENABLED | LAYOUT_DIRECTION_INHERIT`
// Therefore we set the following options as such:
if (ReactNativeFeatureFlags.shouldResetClickableWhenRecyclingView()) {
view.setClickable(ReactNativeFeatureFlags.shouldSetIsClickableByDefault());
}
// NOTE: setClickable MUST be called AFTER setOnClickListener because
// the latter has the side effect of setting isClickable=true on some views!
if (ReactNativeFeatureFlags.shouldResetOnClickListenerWhenRecyclingView()) {
view.setOnClickListener(null);
}
if (ReactNativeFeatureFlags.shouldResetClickableWhenRecyclingView()) {
view.setClickable(ReactNativeFeatureFlags.shouldSetIsClickableByDefault());
}
view.setFocusable(false);
view.setFocusableInTouchMode(false);