Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

do not expose logger from RCTHost (#37235)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37235

Changelog: [Internal]

we shouldn't expose the logger, only need to expose the logging information

Reviewed By: javache

Differential Revision: D45513780

fbshipit-source-id: b82496ebcbf87d7f88d6c7e1afea655d4177a0d8
This commit is contained in:
Phillip Pan
2023-05-03 12:08:19 -07:00
committed by Facebook GitHub Bot
parent 71fbb0cea3
commit b07c81268b
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.h
+1 -2
View File
@@ -20,7 +20,6 @@ NS_ASSUME_NONNULL_BEGIN
@class RCTFabricSurface;
@class RCTJSThreadManager;
@class RCTModuleRegistry;
@class RCTPerformanceLogger;
@protocol RCTInstanceDelegate;
FB_RUNTIME_PROTOCOL
@protocol RCTTurboModuleManagerDelegate;
@@ -74,7 +73,7 @@ RCT_EXTERN NSString *const RCTHostDidReloadNotification;
- (RCTModuleRegistry *)getModuleRegistry FB_OBJC_DIRECT;
- (RCTPerformanceLogger *)getPerformanceLogger FB_OBJC_DIRECT;
- (NSArray *)getLoggingData FB_OBJC_DIRECT;
- (RCTSurfacePresenter *)getSurfacePresenter FB_OBJC_DIRECT;
packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.mm
+3 -2
View File
@@ -14,6 +14,7 @@
#import <React/RCTFabricSurface.h>
#import <React/RCTJSThread.h>
#import <React/RCTLog.h>
#import <React/RCTPerformanceLogger.h>
#import <React/RCTReloadCommand.h>
using namespace facebook::react;
@@ -201,9 +202,9 @@ NSString *const RCTHostDidReloadNotification = @"RCTHostDidReloadNotification";
return _moduleRegistry;
}
- (RCTPerformanceLogger *)getPerformanceLogger
- (NSArray *)getLoggingData
{
return [_instance performanceLogger];
return [[_instance performanceLogger] valuesForTags];
}
- (RCTSurfacePresenter *)getSurfacePresenter