Use in console.timeStamp (#54339)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/54339

# Changelog: [Internal]

Whenever the `console.timeStamp()` is called and we are actually tracing, we will peek at the `ConsoleTaskOrchestrator` stack and check if there is a task.

If so, it means that this call happened inside a task context, so we can request a stack trace and propagate it down to `PerformanceTracer`.

Reviewed By: huntie

Differential Revision: D85481866

fbshipit-source-id: 5bb7c4b7505f0811eff91eed53dc7822a0c063eb
This commit is contained in:
Ruslan Lesiutin authored and meta-codesync[bot] committed 2025-11-06 04:25:36 -08:00
1 parent d6e70791d8
commit af23d4e1f0
3 files changed
+22 -3

No files matched your search

@@ -7,6 +7,7 @@
#include "ConsoleTask.h"
#include "ConsoleTaskContext.h"
#include "ConsoleTaskOrchestrator.h"
#include <jsinspector-modern/RuntimeTarget.h>
#include <jsinspector-modern/tracing/PerformanceTracer.h>
@@ -480,8 +481,17 @@ void consoleTimeStamp(
}
if (performanceTracer.isTracing()) {
auto taskContext = ConsoleTaskOrchestrator::getInstance().top();
performanceTracer.reportTimeStamp(
label, start, end, trackName, trackGroup, color, std::move(detail));
label,
start,
end,
trackName,
trackGroup,
color,
std::move(detail),
taskContext ? taskContext->getSerializedStackTraceProvider() : nullptr);
}
if (ReactPerfettoLogger::isTracing()) {
@@ -214,7 +214,8 @@ void PerformanceTracer::reportTimeStamp(
std::optional<std::string> trackName,
std::optional<std::string> trackGroup,
std::optional<ConsoleTimeStampColor> color,
std::optional<folly::dynamic> detail) {
std::optional<folly::dynamic> detail,
std::function<std::optional<folly::dynamic>()>&& stackTraceProvider) {
if (!tracingAtomic_) {
return;
}
@@ -233,6 +234,7 @@ void PerformanceTracer::reportTimeStamp(
.trackGroup = std::move(trackGroup),
.color = std::move(color),
.detail = std::move(detail),
.stackTraceProvider = std::move(stackTraceProvider),
.threadId = getCurrentThreadId(),
});
}
@@ -695,6 +697,11 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
}
data["devtools"] = folly::toJson(devtoolsDetail);
}
if (event.stackTraceProvider) {
if (auto maybeStackTrace = event.stackTraceProvider()) {
data["rnStackTrace"] = std::move(*maybeStackTrace);
}
}
events.emplace_back(
TraceEvent{
@@ -97,7 +97,8 @@ class PerformanceTracer {
std::optional<std::string> trackName = std::nullopt,
std::optional<std::string> trackGroup = std::nullopt,
std::optional<ConsoleTimeStampColor> color = std::nullopt,
std::optional<folly::dynamic> detail = std::nullopt);
std::optional<folly::dynamic> detail = std::nullopt,
std::function<std::optional<folly::dynamic>()> &&stackTraceProvider = nullptr);
/**
* Record an Event Loop tick, which will be represented as an Event Loop task
@@ -267,6 +268,7 @@ class PerformanceTracer {
std::optional<std::string> trackGroup;
std::optional<ConsoleTimeStampColor> color;
std::optional<folly::dynamic> detail;
std::function<std::optional<folly::dynamic>()> stackTraceProvider;
ThreadId threadId;
HighResTimeStamp createdAt = HighResTimeStamp::now();
};