mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Restore RCTBridge enqueueJSCall compatibility
## Summary: Restores only the four-argument RCTBridge selector enqueueJSCall:method:args:completion: that was removed by #59429. @react-native-firebase/app uses this selector in RNFBRCTEventEmitter to forward native Firebase events to RCTDeviceEventEmitter. Its iOS nightly build fails with: no visible @interface for RCTBridge declares the selector enqueueJSCall:method:args:completion: RCTBridgeProxy still implements the selector and forwards calls to RCTCallableJSModules. This restores source compatibility without bringing back the other removed bridge APIs or the skipped logging tests. Failing nightly job: https://github.com/react-native-community/nightly-tests/actions/runs/43015178202/job/130504459789 ## Changelog: [IOS] [FIXED] - Restore RCTBridge enqueueJSCall compatibility for external libraries ## Test Plan: - node scripts/clang-format.js --check packages/react-native/React/Base/RCTBridge.h packages/react-native/React/Base/RCTBridge.mm - passed. - git diff HEAD^ HEAD --check - passed. - The C++ API generator completed all four Apple views and produced the restored selector entry. The complete cross-platform run then failed in the Android views on an unrelated duplicate basic_appender parser error. Differential Revision: D131220385 Pull Request resolved: https://github.com/react/react-native/pull/59938
This commit is contained in:
1 parent
b8f0db7130
commit
aedc2e739a
6 files changed
+21
No files matched your search
@@ -85,6 +85,16 @@ RCT_EXTERN_C_END
|
||||
*/
|
||||
@interface RCTBridge : NSObject <RCTInvalidating>
|
||||
|
||||
/**
|
||||
* This method is used to call functions in the JavaScript application context.
|
||||
* It is primarily intended for use by modules that require two-way communication
|
||||
* with the JavaScript code. Safe to call from any thread.
|
||||
*/
|
||||
- (void)enqueueJSCall:(NSString *)module
|
||||
method:(NSString *)method
|
||||
args:(NSArray *)args
|
||||
completion:(dispatch_block_t)completion;
|
||||
|
||||
/**
|
||||
* This method registers the file path of an additional JS segment by its ID.
|
||||
*
|
||||
|
||||
@@ -217,6 +217,13 @@ void RCTSetTurboModuleInteropBridgeProxyLogLevel(RCTBridgeProxyLoggingLevel logL
|
||||
}
|
||||
|
||||
@implementation RCTBridge
|
||||
- (void)enqueueJSCall:(NSString *)module
|
||||
method:(NSString *)method
|
||||
args:(NSArray *)args
|
||||
completion:(__strong dispatch_block_t)completion
|
||||
{
|
||||
}
|
||||
|
||||
- (void)registerSegmentWithId:(NSUInteger)segmentId path:(NSString *)path
|
||||
{
|
||||
}
|
||||
|
||||
@@ -662,6 +662,7 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
|
||||
public virtual id moduleForClass:(Class moduleClass);
|
||||
public virtual id moduleForName:(NSString* moduleName);
|
||||
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
|
||||
public virtual void enqueueJSCall:method:args:completion:(NSString* module, NSString* method, NSArray* args, dispatch_block_t completion);
|
||||
public virtual void onFastRefresh();
|
||||
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
|
||||
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);
|
||||
|
||||
@@ -671,6 +671,7 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
|
||||
public virtual id moduleForClass:(Class moduleClass);
|
||||
public virtual id moduleForName:(NSString* moduleName);
|
||||
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
|
||||
public virtual void enqueueJSCall:method:args:completion:(NSString* module, NSString* method, NSArray* args, dispatch_block_t completion);
|
||||
public virtual void onFastRefresh();
|
||||
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
|
||||
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);
|
||||
|
||||
@@ -662,6 +662,7 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
|
||||
public virtual id moduleForClass:(Class moduleClass);
|
||||
public virtual id moduleForName:(NSString* moduleName);
|
||||
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
|
||||
public virtual void enqueueJSCall:method:args:completion:(NSString* module, NSString* method, NSArray* args, dispatch_block_t completion);
|
||||
public virtual void onFastRefresh();
|
||||
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
|
||||
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);
|
||||
|
||||
@@ -662,6 +662,7 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
|
||||
public virtual id moduleForClass:(Class moduleClass);
|
||||
public virtual id moduleForName:(NSString* moduleName);
|
||||
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
|
||||
public virtual void enqueueJSCall:method:args:completion:(NSString* module, NSString* method, NSArray* args, dispatch_block_t completion);
|
||||
public virtual void onFastRefresh();
|
||||
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
|
||||
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);
|
||||
|
||||
Reference in new issue
Block a user