mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix Xcode bundler in staging and release (#29477)
Summary: Revert "feat: improve monorepo support by removing redundant PROJECT_ROOT (https://github.com/facebook/react-native/issues/28354)" This reverts commita8e85026cf. This commita8e85026cfsomehow broke the bundler when making a staging or release build in Xcode that results in unresolved files and main.jsbundle nonexistance issue. I figured this out by replacing react-native-xcode.sh from RN v0.63.2 by the one from v0.62.2 where everything works just fine and then reverting the changes line by line. It seems like this pr will fix similar issues stated here https://stackoverflow.com/questions/62806319/main-jsbundle-does-not-exist-this-must-be-a-bug-with-main-jsbundle-issue-afte/62829256#62829256 and here https://github.com/facebook/react-native/issues/29205 ## Changelog [iOS] [Fixed] - fix "main.jsbundle does not exist" issue Pull Request resolved: https://github.com/facebook/react-native/pull/29477 Test Plan: With react-native-xcode.sh from RN v0.63.2  With my changes  Reviewed By: sammy-SC Differential Revision: D23817847 Pulled By: hramos fbshipit-source-id: 4b729c1231d30e89073b2520aeadee944c84421c
This commit is contained in:
committed by
Lorenzo Sciandra
parent
66c8cd393c
commit
ad6005f6bc
@@ -54,17 +54,11 @@ case "$CONFIGURATION" in
|
||||
;;
|
||||
esac
|
||||
|
||||
# Setting up a project root was a workaround to enable support for non-standard
|
||||
# structures, including monorepos. Today, CLI supports that out of the box
|
||||
# and setting custom `PROJECT_ROOT` only makes it confusing.
|
||||
#
|
||||
# As a backwards-compatible change, I am leaving "PROJECT_ROOT" support for those
|
||||
# who already use it - it is likely a non-breaking removal.
|
||||
#
|
||||
# For new users, we default to $PWD - not changing things all.
|
||||
#
|
||||
# For context: https://github.com/facebook/react-native/commit/9ccde378b6e6379df61f9d968be6346ca6be7ead#commitcomment-37914902
|
||||
PROJECT_ROOT=${PROJECT_ROOT:-$PWD}
|
||||
# Path to react-native folder inside node_modules
|
||||
REACT_NATIVE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
|
||||
# The project should be located next to where react-native is installed
|
||||
# in node_modules.
|
||||
PROJECT_ROOT=${PROJECT_ROOT:-"$REACT_NATIVE_DIR/../.."}
|
||||
|
||||
cd "$PROJECT_ROOT" || exit
|
||||
|
||||
@@ -102,9 +96,6 @@ if [[ ! -x node && -d ${HOME}/.anyenv/bin ]]; then
|
||||
fi
|
||||
fi
|
||||
|
||||
# Path to react-native folder inside node_modules
|
||||
REACT_NATIVE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
|
||||
|
||||
# check and assign NODE_BINARY env
|
||||
# shellcheck source=/dev/null
|
||||
source "$REACT_NATIVE_DIR/scripts/node-binary.sh"
|
||||
|
||||
Reference in New Issue
Block a user