mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix MountingCoordinator override mode
Summary: In MountingCoordinator override mode (used in LayoutAnimations) we must set the start and end `diff` time when no real diff happens, otherwise we will hit an assert in telemetry later. I also ensure that the TransactionNumber is incremented in that case. Changelog: [Internal] Reviewed By: shergin Differential Revision: D23746684 fbshipit-source-id: b1fe3864e453fdba89d43cc827bd37434abf7a4d
This commit is contained in:
committed by
Facebook GitHub Bot
parent
012ac09fa1
commit
ad400f3cf6
@@ -117,10 +117,13 @@ better::optional<MountingTransaction> MountingCoordinator::pullTransaction()
|
||||
mutations = transaction->getMutations();
|
||||
telemetry = transaction->getTelemetry();
|
||||
} else {
|
||||
number_++;
|
||||
telemetry.willLayout();
|
||||
telemetry.didLayout();
|
||||
telemetry.willCommit();
|
||||
telemetry.didCommit();
|
||||
telemetry.willDiff();
|
||||
telemetry.didDiff();
|
||||
}
|
||||
|
||||
transaction = mountingOverrideDelegate->pullTransaction(
|
||||
|
||||
Reference in New Issue
Block a user