Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't show "Hot Reloading" banner on first load

Browse Source 
Summary:
D10527979 made the "update" message sequence part of initial connection signals. But the HMR client uses this sequence as a signal to show "Hot Reloading..." bar. As a result, we were showing it on every initial load when Hot Reloading is on. This is very confusing.

As a simple fix, I now send an explicit message to mark the end of the first load. I could infer that by first update message but figured this is more explicit and less likely to break. Until we receive `connection-done`, we now don't attempt to show the "Hot Reloading..." bar.

Reviewed By: rubennorte

Differential Revision: D15936085

fbshipit-source-id: b18b6aceea6c47d919b4265e58b21fc44f77b0b3
This commit is contained in:
Dan Abramov
2019-06-21 06:04:19 -07:00
committed by Facebook Github Bot
parent d7c8ace001
commit acd349e35a
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Utilities/HMRClient.js
+12 -2
View File
@@ -69,8 +69,16 @@ Error: ${e.message}`;
throw new Error(error);
});
let enableLoadingView = false;
hmrClient.on('connection-done', () => {
// Don't show the loading view during the initial update.
enableLoadingView = true;
});
hmrClient.on('update-start', () => {
HMRLoadingView.showMessage('Hot Reloading...');
if (enableLoadingView) {
HMRLoadingView.showMessage('Hot Reloading...');
}
});
hmrClient.on('update', () => {
@@ -90,7 +98,9 @@ Error: ${e.message}`;
});
hmrClient.on('update-done', () => {
HMRLoadingView.hide();
if (enableLoadingView) {
HMRLoadingView.hide();
}
});
hmrClient.on('error', data => {