Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor creation of MountItems (#36605)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36605

This diff introduces the class MountItemFactory that will be used to create MountItems in Fabric.
The purpose of this refactor is to reduce visibility for custom implementations of MountItems

This should not be a breaking change, because nobody should be using these classes

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D44115053

fbshipit-source-id: a62d0a42239d29380aa10d5eab428af90c313d00
This commit is contained in:
David Vacca
2023-03-30 18:32:12 -07:00
committed by Facebook GitHub Bot
parent c76ab8d01d
commit aa3e087be1
4 changed files with 35 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
+5 -4
View File
@@ -59,10 +59,9 @@ import com.facebook.react.fabric.mounting.MountItemDispatcher;
import com.facebook.react.fabric.mounting.MountingManager;
import com.facebook.react.fabric.mounting.SurfaceMountingManager;
import com.facebook.react.fabric.mounting.SurfaceMountingManager.ViewEvent;
import com.facebook.react.fabric.mounting.mountitems.DispatchIntCommandMountItem;
import com.facebook.react.fabric.mounting.mountitems.DispatchStringCommandMountItem;
import com.facebook.react.fabric.mounting.mountitems.IntBufferBatchMountItem;
import com.facebook.react.fabric.mounting.mountitems.MountItem;
import com.facebook.react.fabric.mounting.mountitems.MountItemFactory;
import com.facebook.react.fabric.mounting.mountitems.PreAllocateViewMountItem;
import com.facebook.react.fabric.mounting.mountitems.SendAccessibilityEvent;
import com.facebook.react.modules.core.ReactChoreographer;
@@ -1021,7 +1020,8 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
final int commandId,
@Nullable final ReadableArray commandArgs) {
mMountItemDispatcher.dispatchCommandMountItem(
new DispatchIntCommandMountItem(surfaceId, reactTag, commandId, commandArgs));
MountItemFactory.createDispatchCommandMountItem(
surfaceId, reactTag, commandId, commandArgs));
}
@AnyThread
@@ -1032,7 +1032,8 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
final String commandId,
@Nullable final ReadableArray commandArgs) {
mMountItemDispatcher.dispatchCommandMountItem(
new DispatchStringCommandMountItem(surfaceId, reactTag, commandId, commandArgs));
MountItemFactory.createDispatchCommandMountItem(
surfaceId, reactTag, commandId, commandArgs));
}
@Override
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/mountitems/DispatchIntCommandMountItem.java
+1 -1
View File
@@ -12,7 +12,7 @@ import androidx.annotation.Nullable;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.fabric.mounting.MountingManager;
public class DispatchIntCommandMountItem extends DispatchCommandMountItem {
class DispatchIntCommandMountItem extends DispatchCommandMountItem {
private final int mSurfaceId;
private final int mReactTag;
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/mountitems/DispatchStringCommandMountItem.java
+1 -1
View File
@@ -12,7 +12,7 @@ import androidx.annotation.Nullable;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.fabric.mounting.MountingManager;
public class DispatchStringCommandMountItem extends DispatchCommandMountItem {
class DispatchStringCommandMountItem extends DispatchCommandMountItem {
private final int mSurfaceId;
private final int mReactTag;
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/mountitems/MountItemFactory.java
+28
View File
@@ -0,0 +1,28 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
package com.facebook.react.fabric.mounting.mountitems;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import com.facebook.react.bridge.ReadableArray;
/** Factory class that expose creation of {@link MountItem} */
public class MountItemFactory {
/** @return a {@link DispatchCommandMountItem} for commands identified by an int */
public static DispatchCommandMountItem createDispatchCommandMountItem(
int surfaceId, int reactTag, int commandId, @Nullable ReadableArray commandArgs) {
return new DispatchIntCommandMountItem(surfaceId, reactTag, commandId, commandArgs);
}
/** @return a {@link DispatchCommandMountItem} for commands identified by a String */
public static DispatchCommandMountItem createDispatchCommandMountItem(
int surfaceId, int reactTag, @NonNull String commandId, @Nullable ReadableArray commandArgs) {
return new DispatchStringCommandMountItem(surfaceId, reactTag, commandId, commandArgs);
}
}