Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

decouple DialogModuleTest from PowerMock (#36778)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36778

Changelog: [Internal]

we can just use mockito for this suite

Reviewed By: mdvacca

Differential Revision: D44603023

fbshipit-source-id: b8f6f37fccba38990fe498d8f5e479f174ff93af
This commit is contained in:
Phillip Pan
2023-04-04 13:49:37 -07:00
committed by Facebook GitHub Bot
parent 62c4da1421
commit aa15fd44a6
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/dialog/DialogModuleTest.java
+5 -8
View File
@@ -11,6 +11,7 @@ import static android.os.Looper.getMainLooper;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.mockito.Mockito.when;
import static org.robolectric.Shadows.shadowOf;
import android.app.AlertDialog;
@@ -21,18 +22,14 @@ import com.facebook.react.bridge.JavaOnlyMap;
import com.facebook.react.bridge.ReactApplicationContext;
import org.junit.After;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.powermock.api.mockito.PowerMockito;
import org.powermock.core.classloader.annotations.PowerMockIgnore;
import org.mockito.Mockito;
import org.robolectric.Robolectric;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.android.controller.ActivityController;
@RunWith(RobolectricTestRunner.class)
@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
@Ignore("Ignored due to unsupported mocking mechanism with JDK 18")
public class DialogModuleTest {
private ActivityController<FragmentActivity> mActivityController;
@@ -63,9 +60,9 @@ public class DialogModuleTest {
mActivityController = Robolectric.buildActivity(FragmentActivity.class);
mActivity = mActivityController.create().start().resume().get();
final ReactApplicationContext context = PowerMockito.mock(ReactApplicationContext.class);
PowerMockito.when(context.hasActiveReactInstance()).thenReturn(true);
PowerMockito.when(context, "getCurrentActivity").thenReturn(mActivity);
final ReactApplicationContext context = Mockito.mock(ReactApplicationContext.class);
when(context.hasActiveReactInstance()).thenReturn(true);
when(context.getCurrentActivity()).thenReturn(mActivity);
mDialogModule = new DialogModule(context);
mDialogModule.onHostResume();