mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Support pseudo-element shadow node creation for view transitions (#56456)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56456 ## Changelog: [Internal] [Added] - Support pseudo-element shadow node creation for view transitions Implement `createViewTransitionInstance`, which is invoked by the React reconciler to create pseudo-element shadow nodes that visually represent the old state of elements participating in a view transition. Key changes: - Add `createViewTransitionInstance` JSI binding in `UIManagerBinding`, accepting a transition name and pseudo-element tag - Add virtual `createViewTransitionInstance` method to `UIManagerViewTransitionDelegate` - Implement the method in `ViewTransitionModule`: creates an absolutely-positioned, non-interactive `View` shadow node matching the old element's layout metrics (position, size) - Manage two pseudo-element node maps: `oldPseudoElementNodes_` for the current transition and `oldPseudoElementNodesForNextTransition_` for entering nodes that may exit in a future transition - Update `getOldViewTransitionInstance` to return the pseudo-element's tag (instead of the original element's tag) when a pseudo-element exists - Add `applySnapshotsOnPseudoElementShadowNodes` stub for future platform-level bitmap snapshot integration `createViewTransitionInstance` is typically called after `applyViewTransitionName` in the React reconciler. See the diagram below for the full flow. {F1987481080} Reviewed By: Abbondanzo Differential Revision: D98981886 fbshipit-source-id: 46d89eb058da0ad2365d59a905ca9585e015f0e9
This commit is contained in:
1 parent
7171302cc0
commit
a9d567c2d9
4 files changed
+133
-6
No files matched your search
@@ -981,6 +981,37 @@ jsi::Value UIManagerBinding::get(
|
||||
});
|
||||
}
|
||||
|
||||
if (methodName == "createViewTransitionInstance") {
|
||||
auto paramCount = 2;
|
||||
return jsi::Function::createFromHostFunction(
|
||||
runtime,
|
||||
name,
|
||||
paramCount,
|
||||
[uiManager, methodName, paramCount](
|
||||
jsi::Runtime& runtime,
|
||||
const jsi::Value& /*thisValue*/,
|
||||
const jsi::Value* arguments,
|
||||
size_t count) -> jsi::Value {
|
||||
validateArgumentCount(runtime, methodName, paramCount, count);
|
||||
|
||||
auto transitionName = arguments[0].isString()
|
||||
? stringFromValue(runtime, arguments[0])
|
||||
: "";
|
||||
auto pseudoElementTag = tagFromValue(arguments[1]);
|
||||
|
||||
if (!transitionName.empty()) {
|
||||
auto* viewTransitionDelegate =
|
||||
uiManager->getViewTransitionDelegate();
|
||||
if (viewTransitionDelegate != nullptr) {
|
||||
viewTransitionDelegate->createViewTransitionInstance(
|
||||
transitionName, pseudoElementTag);
|
||||
}
|
||||
}
|
||||
|
||||
return jsi::Value::undefined();
|
||||
});
|
||||
}
|
||||
|
||||
if (methodName == "cancelViewTransitionName") {
|
||||
auto paramCount = 2;
|
||||
return jsi::Function::createFromHostFunction(
|
||||
|
||||
+2
@@ -23,6 +23,8 @@ class UIManagerViewTransitionDelegate {
|
||||
{
|
||||
}
|
||||
|
||||
virtual void createViewTransitionInstance(const std::string & /*name*/, Tag /*pseudoElementTag*/) {}
|
||||
|
||||
virtual void cancelViewTransitionName(const ShadowNode &shadowNode, const std::string &name) {}
|
||||
|
||||
virtual void restoreViewTransitionName(const ShadowNode &shadowNode) {}
|
||||
|
||||
+89
-6
@@ -7,9 +7,8 @@
|
||||
|
||||
#include "ViewTransitionModule.h"
|
||||
|
||||
#include <glog/logging.h>
|
||||
|
||||
#include <react/renderer/core/LayoutableShadowNode.h>
|
||||
#include <react/renderer/core/RawProps.h>
|
||||
#include <react/renderer/uimanager/UIManager.h>
|
||||
|
||||
namespace facebook::react {
|
||||
@@ -45,6 +44,16 @@ void ViewTransitionModule::applyViewTransitionName(
|
||||
AnimationKeyFrameView oldView{
|
||||
.layoutMetrics = keyframeMetrics, .tag = tag, .surfaceId = surfaceId};
|
||||
oldLayout_[name] = oldView;
|
||||
|
||||
// TODO: capture bitmap snapshot of old view via platform
|
||||
|
||||
if (auto it = oldPseudoElementNodesForNextTransition_.find(name);
|
||||
it != oldPseudoElementNodesForNextTransition_.end()) {
|
||||
auto pseudoElementNode = it->second;
|
||||
oldPseudoElementNodes_[name] = pseudoElementNode;
|
||||
oldPseudoElementNodesForNextTransition_.erase(it);
|
||||
}
|
||||
|
||||
} else {
|
||||
AnimationKeyFrameView newView{
|
||||
.layoutMetrics = keyframeMetrics, .tag = tag, .surfaceId = surfaceId};
|
||||
@@ -52,6 +61,67 @@ void ViewTransitionModule::applyViewTransitionName(
|
||||
}
|
||||
}
|
||||
|
||||
void ViewTransitionModule::createViewTransitionInstance(
|
||||
const std::string& name,
|
||||
Tag pseudoElementTag) {
|
||||
if (uiManager_ == nullptr) {
|
||||
return;
|
||||
}
|
||||
|
||||
// if createViewTransitionInstance is called before transition started, it
|
||||
// creates the old pseudo elements for exiting nodes that potentially
|
||||
// participate in current transition that's about to happen; if called after
|
||||
// transition started, it creates old pseudo elements for entering nodes, and
|
||||
// will be used in next transition when these node are exiting
|
||||
bool forNextTransition = false;
|
||||
AnimationKeyFrameView view = {};
|
||||
auto it = oldLayout_.find(name);
|
||||
if (it == oldLayout_.end()) {
|
||||
forNextTransition = true;
|
||||
if (auto newIt = newLayout_.find(name); newIt != newLayout_.end()) {
|
||||
view = newIt->second;
|
||||
}
|
||||
} else {
|
||||
view = it->second;
|
||||
}
|
||||
|
||||
// Build props: absolute position matching old element, non-interactive
|
||||
if (pseudoElementTag > 0 && view.tag > 0) {
|
||||
// Create a base node with layout props via createNode
|
||||
// TODO: T262559684 created dedicated shadow node type for old pseudo
|
||||
// element
|
||||
auto rawProps = RawProps(
|
||||
folly::dynamic::object("position", "absolute")(
|
||||
"left", view.layoutMetrics.originFromRoot.x)(
|
||||
"top", view.layoutMetrics.originFromRoot.y)(
|
||||
"width", view.layoutMetrics.size.width)(
|
||||
"height", view.layoutMetrics.size.height)("pointerEvents", "none")(
|
||||
"opacity", 0)("collapsable", false));
|
||||
|
||||
auto baseNode = uiManager_->createNode(
|
||||
pseudoElementTag,
|
||||
"View",
|
||||
view.surfaceId,
|
||||
std::move(rawProps),
|
||||
nullptr /* instanceHandle */);
|
||||
|
||||
if (baseNode == nullptr) {
|
||||
return;
|
||||
}
|
||||
|
||||
// Clone the shadow node — bitmap will be set by platform
|
||||
auto pseudoElementNode = baseNode->clone({});
|
||||
|
||||
if (pseudoElementNode != nullptr) {
|
||||
if (!forNextTransition) {
|
||||
oldPseudoElementNodes_[name] = pseudoElementNode;
|
||||
} else {
|
||||
oldPseudoElementNodesForNextTransition_[name] = pseudoElementNode;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
void ViewTransitionModule::cancelViewTransitionName(
|
||||
const ShadowNode& shadowNode,
|
||||
const std::string& name) {
|
||||
@@ -67,6 +137,14 @@ void ViewTransitionModule::restoreViewTransitionName(
|
||||
cancelledNameRegistry_.erase(shadowNode.getTag());
|
||||
}
|
||||
|
||||
void ViewTransitionModule::applySnapshotsOnPseudoElementShadowNodes() {
|
||||
if (oldPseudoElementNodes_.empty() || uiManager_ == nullptr) {
|
||||
return;
|
||||
}
|
||||
|
||||
// TODO: set bitmap snapshots on pseudo-element views via platform
|
||||
}
|
||||
|
||||
LayoutMetrics ViewTransitionModule::captureLayoutMetricsFromRoot(
|
||||
const ShadowNode& shadowNode) {
|
||||
if (uiManager_ == nullptr) {
|
||||
@@ -100,13 +178,13 @@ void ViewTransitionModule::startViewTransition(
|
||||
// Mark transition as started
|
||||
transitionStarted_ = true;
|
||||
|
||||
// Call mutation callback (including commitRoot, measureInstance
|
||||
// applyViewTransitionName for old & new)
|
||||
// Call mutation callback (including commitRoot, measureInstance,
|
||||
// applyViewTransitionName, createViewTransitionInstance for old & new)
|
||||
if (mutationCallback) {
|
||||
mutationCallback();
|
||||
}
|
||||
|
||||
// TODO: capture pseudo elements
|
||||
applySnapshotsOnPseudoElementShadowNodes();
|
||||
|
||||
if (onReadyCallback) {
|
||||
onReadyCallback();
|
||||
@@ -128,6 +206,7 @@ void ViewTransitionModule::startViewTransitionEnd() {
|
||||
}
|
||||
}
|
||||
nameRegistry_.clear();
|
||||
oldPseudoElementNodes_.clear();
|
||||
|
||||
transitionStarted_ = false;
|
||||
}
|
||||
@@ -152,12 +231,16 @@ ViewTransitionModule::getViewTransitionInstance(
|
||||
auto it = oldLayout_.find(name);
|
||||
if (it != oldLayout_.end()) {
|
||||
const auto& view = it->second;
|
||||
auto pseudoElementIt = oldPseudoElementNodes_.find(name);
|
||||
auto nativeTag = pseudoElementIt != oldPseudoElementNodes_.end()
|
||||
? pseudoElementIt->second->getTag()
|
||||
: view.tag;
|
||||
return ViewTransitionInstance{
|
||||
.x = view.layoutMetrics.originFromRoot.x,
|
||||
.y = view.layoutMetrics.originFromRoot.y,
|
||||
.width = view.layoutMetrics.size.width,
|
||||
.height = view.layoutMetrics.size.height,
|
||||
.nativeTag = view.tag};
|
||||
.nativeTag = nativeTag};
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
+11
@@ -29,6 +29,10 @@ class ViewTransitionModule : public UIManagerViewTransitionDelegate {
|
||||
void applyViewTransitionName(const ShadowNode &shadowNode, const std::string &name, const std::string &className)
|
||||
override;
|
||||
|
||||
// creates a pseudo-element shadow node for a given transition name using the
|
||||
// captured old layout metrics
|
||||
void createViewTransitionInstance(const std::string &name, Tag pseudoElementTag) override;
|
||||
|
||||
// if a viewTransitionName is cancelled, the element doesn't have view-transition-name and browser won't be taking
|
||||
// snapshot
|
||||
void cancelViewTransitionName(const ShadowNode &shadowNode, const std::string &name) override;
|
||||
@@ -72,8 +76,15 @@ class ViewTransitionModule : public UIManagerViewTransitionDelegate {
|
||||
// used for cancel/restore viewTransitionName
|
||||
std::unordered_map<Tag, std::unordered_set<std::string>> cancelledNameRegistry_{};
|
||||
|
||||
// pseudo-element nodes keyed by transition name
|
||||
std::unordered_map<std::string, std::shared_ptr<const ShadowNode>> oldPseudoElementNodes_{};
|
||||
// will be restored into oldPseudoElementNodes_ in next transition
|
||||
std::unordered_map<std::string, std::shared_ptr<const ShadowNode>> oldPseudoElementNodesForNextTransition_{};
|
||||
|
||||
LayoutMetrics captureLayoutMetricsFromRoot(const ShadowNode &shadowNode);
|
||||
|
||||
void applySnapshotsOnPseudoElementShadowNodes();
|
||||
|
||||
UIManager *uiManager_{nullptr};
|
||||
|
||||
bool transitionStarted_{false};
|
||||
|
||||
Reference in new issue
Block a user