Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix typo in Value's constructor with a Symbol

Browse Source 
Summary:
The current JSI implementation is converting a Symbol to String when creating a jsi Value.

Changelog: [General][Fixed]

Reviewed By: neildhar

Differential Revision: D35705825

fbshipit-source-id: 3bee0a02bb77643c6a33031b4d98ac9a7e126303
This commit is contained in:
John Porto
2022-04-17 11:53:12 -07:00
committed by Facebook GitHub Bot
parent 3c1a814465
commit a7a0f86a73
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/jsi/jsi/jsi.h
+1 -1
View File
@@ -992,7 +992,7 @@ class JSI_EXPORT Value {
/// Copies a Symbol lvalue into a new JS value.
Value(Runtime& runtime, const Symbol& sym) : Value(SymbolKind) {
new (&data_.pointer) String(runtime.cloneSymbol(sym.ptr_));
new (&data_.pointer) Symbol(runtime.cloneSymbol(sym.ptr_));
}
/// Copies a String lvalue into a new JS value.