rename PopupMenuAndroid.onPopupDismiss (#44109)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/44109

(Following up from suggestion of prior diff)
For consistency with `OnSelectionChange` callback, rename `onPopupDismiss` to `onDismiss`.

Changelog:
[Android][Internal] - rename function

Reviewed By: RSNara

Differential Revision: D56168456

fbshipit-source-id: c4a32637951200736202f43294973d783ecf5ace

packages/react-native-popup-menu-android/js/PopupMenuAndroid.android.js

@@ -34,7 +34,7 @@ export type PopupMenuAndroidInstance = {
 type Props = {
   menuItems: $ReadOnlyArray<string>,
   onSelectionChange: number => void,
-  onPopupDismiss?: () => void,
+  onDismiss?: () => void,
   children: React.Node,
   instanceRef: RefObject<?PopupMenuAndroidInstance>,
 };
@@ -42,7 +42,7 @@ type Props = {
 export default function PopupMenuAndroid({
   menuItems,
   onSelectionChange,
-  onPopupDismiss,
+  onDismiss,
   children,
   instanceRef,
 }: Props): React.Node {
@@ -53,11 +53,11 @@ export default function PopupMenuAndroid({
     },
     [onSelectionChange],
   );
-  const _onPopupDismiss = useCallback(
+  const _onDismiss = useCallback(
     (event: PopupMenuDismissEvent) => {
-      onPopupDismiss?.();
+      onDismiss?.();
     },
-    [onPopupDismiss],
+    [onDismiss],
   );
 
   useImperativeHandle(instanceRef, ItemViewabilityInstance => {
@@ -72,7 +72,7 @@ export default function PopupMenuAndroid({
     <PopupMenuAndroidNativeComponent
       ref={nativeRef}
       onPopupMenuSelectionChange={_onSelectionChange}
-      onPopupMenuDismiss={_onPopupDismiss}
+      onPopupMenuDismiss={_onDismiss}
       menuItems={menuItems}>
       {children}
     </PopupMenuAndroidNativeComponent>

packages/react-native-popup-menu-android/js/PopupMenuAndroid.d.ts

@@ -17,6 +17,7 @@ type PopupMenuAndroidInstance = {
 type Props = {
   menuItems: Array<string>;
   onSelectionChange: (number) => void;
+  onDismiss: () => void;
   children: React.ReactNode | undefined;
   instanceRef: React.ElementRef<HostComponent<PopupMenuAndroidInstance>>;
 };

packages/react-native-popup-menu-android/js/PopupMenuAndroid.js

@@ -43,7 +43,7 @@ export type PopupMenuAndroidInstance = {
 type Props = {
   menuItems: $ReadOnlyArray<string>,
   onSelectionChange: number => void,
-  onPopupDismiss?: () => void,
+  onDismiss?: () => void,
   children: Node,
   instanceRef: RefObject<?PopupMenuAndroidInstance>,
 };

packages/rn-tester/js/examples/PopupMenuAndroid/PopupMenuAndroidExample.js

@@ -37,7 +37,7 @@ const PopupMenu = () => {
         instanceRef={popupRef}
         menuItems={items.map(({label}) => label)}
         onSelectionChange={selection => items[selection].onPress()}
-        onPopupDismiss={() => console.warn('Popup was dismissed!')}>
+        onDismiss={() => console.warn('Popup was dismissed!')}>
         <Button
           title="Show PopupMenu!"
           onPress={() => {