Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unify ref usages in TS type tests (#51117)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/51117

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D74240080

fbshipit-source-id: 5cc7042b5ac1515887d20b72a0b7d96cc8313ed7
This commit is contained in:
Jakub Piasecki
2025-05-06 05:42:29 -07:00
committed by Facebook GitHub Bot
parent ef6f2fb32d
commit a65744fd4a
2 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/types/__typetests__/animated.tsx
+11 -7
View File
@@ -31,7 +31,10 @@ class Comp extends React.Component<CompProps> {
}
}
const ForwardComp = React.forwardRef<View, CompProps>(({width}, ref) => {
const ForwardComp = React.forwardRef<
React.ComponentRef<typeof View>,
CompProps
>(({width}, ref) => {
function f1(): boolean {
return true;
}
@@ -53,7 +56,7 @@ function TestAnimatedAPI() {
const v2 = new Animated.Value(0);
// Ref
const AnimatedViewRef = React.useRef<View>(null);
const AnimatedViewRef = React.useRef<React.ComponentRef<typeof View>>(null);
AnimatedViewRef.current &&
AnimatedViewRef.current.measure(() => {
@@ -62,15 +65,15 @@ function TestAnimatedAPI() {
const AnimatedComp = Animated.createAnimatedComponent(Comp);
const AnimatedCompRef = React.useRef<Comp>(null);
const AnimatedCompRef = React.useRef<React.ComponentRef<typeof Comp>>(null);
AnimatedCompRef.current && AnimatedCompRef.current.f1();
const AnimatedForwardComp = Animated.createAnimatedComponent(ForwardComp);
const AnimatedForwardCompRef =
React.useRef<React.ElementRef<typeof ForwardComp>>(null);
const ForwardCompRef = React.useRef<View>(null);
React.useRef<React.ComponentRef<typeof ForwardComp>>(null);
const ForwardCompRef = React.useRef<React.ComponentRef<typeof View>>(null);
AnimatedForwardCompRef.current &&
AnimatedForwardCompRef.current.measure(() => {
@@ -168,8 +171,9 @@ function TestAnimatedAPI() {
});
const AnimatedView = Animated.createAnimatedComponent(View);
const ref = React.useRef<View>(null);
const legacyRef = React.useRef<Animated.LegacyRef<View>>(null);
const ref = React.useRef<React.ComponentRef<typeof View>>(null);
const legacyRef =
React.useRef<Animated.LegacyRef<React.ComponentRef<typeof View>>>(null);
return (
<View ref={ref}>
packages/react-native/types/__typetests__/index.tsx
+8 -8
View File
@@ -429,8 +429,8 @@ class CustomView extends React.Component {
class Welcome extends React.Component<
ElementProps<View> & {color: string; bgColor?: null | undefined | string}
> {
rootViewRef = React.createRef<View>();
customViewRef = React.createRef<CustomView>();
rootViewRef = React.createRef<React.ComponentRef<typeof View>>();
customViewRef = React.createRef<React.ComponentRef<typeof CustomView>>();
testNativeMethods() {
if (this.rootViewRef.current != null) {
@@ -498,7 +498,7 @@ function TouchableTest() {
}
export class TouchableHighlightTest extends React.Component {
buttonRef = React.createRef<React.ElementRef<typeof TouchableHighlight>>();
buttonRef = React.createRef<React.ComponentRef<typeof TouchableHighlight>>();
render() {
return (
@@ -525,7 +525,7 @@ export class TouchableHighlightTest extends React.Component {
}
export class TouchableOpacityTest extends React.Component {
buttonRef = React.createRef<React.ElementRef<typeof TouchableOpacity>>();
buttonRef = React.createRef<React.ComponentRef<typeof TouchableOpacity>>();
render() {
return (
@@ -720,7 +720,7 @@ export class PressableTest extends React.Component<{}> {
}
// App State
function appStateListener(state: string) {
function appStateListener(state?: string) {
console.log('New state: ' + state);
}
@@ -1575,7 +1575,7 @@ class BridgedComponentTest extends React.Component {
}
const SafeAreaViewTest = () => {
const viewRef = React.createRef<React.ElementRef<typeof View>>();
const viewRef = React.createRef<React.ComponentRef<typeof View>>();
return (
<>
@@ -1600,7 +1600,7 @@ const SafeAreaViewTest = () => {
};
const SwitchRefTest = () => {
const switchRef = React.createRef<React.ElementRef<typeof Switch>>();
const switchRef = React.createRef<React.ComponentRef<typeof Switch>>();
return (
<>
@@ -2103,7 +2103,7 @@ const AccessibilityCustomActionsTest = () => {
// DrawerLayoutAndroidTest
export class DrawerLayoutAndroidTest extends React.Component {
drawerRef = React.createRef<DrawerLayoutAndroid>();
drawerRef = React.createRef<React.ComponentRef<typeof DrawerLayoutAndroid>>();
readonly styles = StyleSheet.create({
container: {