Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use ReactNativeFeatureFlagsForTests in uimanager tests (#50594)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50594

Some tests are failing due to unsatisfied error when looking for C++ classes of feature flags, we fix this by calling ReactNativeFeatureFlagsForTests.setup()

changelog: [internal] internal

Reviewed By: yungsters, sbuggay

Differential Revision: D72721786

fbshipit-source-id: c41c05428b1f99db9b03bb67cd9ddc47ebec84b5
This commit is contained in:
David Vacca
2025-04-09 10:41:50 -07:00
committed by Facebook GitHub Bot
parent 06ad33b511
commit a649100299
11 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/BorderRadiusStyleTest.kt
+7
View File
@@ -8,11 +8,13 @@
package com.facebook.react.uimanager
import android.content.Context
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.uimanager.style.BorderRadiusProp
import com.facebook.react.uimanager.style.BorderRadiusStyle
import com.facebook.react.uimanager.style.ComputedBorderRadiusProp
import com.facebook.react.uimanager.style.CornerRadii
import org.assertj.core.api.Assertions.*
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
@@ -67,6 +69,11 @@ class BorderRadiusStyleTest {
}
}
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
}
@Test
fun testCorrectPriorityRTL() {
setContextLeftAndRightSwap(ctx, true)
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/JSPointerDispatcherTest.kt
+2
View File
@@ -15,6 +15,7 @@ import android.view.View
import android.view.ViewGroup
import android.widget.LinearLayout
import android.widget.TextView
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.uimanager.events.Event
import com.facebook.react.uimanager.events.EventDispatcher
import com.facebook.react.uimanager.events.PointerEventHelper
@@ -42,6 +43,7 @@ class JSPointerDispatcherTest {
@Before
fun setupViewHierarchy() {
ReactNativeFeatureFlagsForTests.setUp()
val ctx: Context = RuntimeEnvironment.getApplication()
root = LinearLayout(ctx)
val childView = TextView(ctx)
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/MatrixMathHelperTest.kt
+7
View File
@@ -7,15 +7,22 @@
package com.facebook.react.uimanager
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.uimanager.MatrixMathHelper.MatrixDecompositionContext
import kotlin.math.cos
import kotlin.math.sin
import org.assertj.core.api.Assertions.assertThat
import org.junit.Before
import org.junit.Test
/** Test for [MatrixMathHelper] */
class MatrixMathHelperTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
}
@Test
fun testDecomposing4x4MatrixToProduceAccurateZaxisAngles() {
val ctx = MatrixDecompositionContext()
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/OnLayoutEventTest.kt
+2
View File
@@ -8,6 +8,7 @@
package com.facebook.react.uimanager
import com.facebook.react.common.SystemClock
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import org.assertj.core.api.Assertions.assertThat
import org.junit.After
import org.junit.Before
@@ -23,6 +24,7 @@ class OnLayoutEventTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
val ts = SystemClock.uptimeMillis()
systemClock = mockStatic(SystemClock::class.java)
systemClock.`when`<Long> { SystemClock.uptimeMillis() }.thenReturn(ts)
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropAnnotationSetterSpecTest.kt
+7
View File
@@ -8,9 +8,11 @@
package com.facebook.react.uimanager
import android.view.View
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.uimanager.annotations.ReactProp
import com.facebook.react.uimanager.annotations.ReactPropGroup
import java.util.Date
import org.junit.Before
import org.junit.Test
/** Test that verifies that spec of methods annotated with @ReactProp is correct */
@@ -31,6 +33,11 @@ class ReactPropAnnotationSetterSpecTest {
override fun updateExtraData(root: View, extraData: Any) = Unit
}
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
}
@Test(expected = RuntimeException::class)
fun testMethodWithWrongNumberOfParams() {
object : BaseViewManager() {
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropAnnotationSetterTest.kt
+2
View File
@@ -13,6 +13,7 @@ import com.facebook.react.bridge.JavaOnlyArray
import com.facebook.react.bridge.JavaOnlyMap
import com.facebook.react.bridge.ReadableArray
import com.facebook.react.bridge.ReadableMap
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.uimanager.annotations.ReactProp
import com.facebook.react.uimanager.annotations.ReactPropGroup
import org.junit.Before
@@ -172,6 +173,7 @@ class ReactPropAnnotationSetterTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
updatesReceiverMock = Mockito.mock(ViewManagerUpdatesReceiver::class.java)
viewManager = ViewManagerUnderTest(updatesReceiverMock)
targetView = View(RuntimeEnvironment.getApplication())
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropConstantsTest.kt
+7
View File
@@ -11,9 +11,11 @@ import android.view.View
import com.facebook.react.bridge.BridgeReactContext
import com.facebook.react.bridge.ReadableArray
import com.facebook.react.bridge.ReadableMap
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.uimanager.annotations.ReactProp
import com.facebook.react.uimanager.annotations.ReactPropGroup
import org.assertj.core.api.Assertions
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
@@ -84,6 +86,11 @@ class ReactPropConstantsTest {
fun customIntGroupProp(v: View?, index: Int, value: Int?) = Unit
}
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
}
@Test
fun testNativePropsIncludeCorrectTypes() {
val viewManagers = listOf<ViewManager<*, *>>(ViewManagerUnderTest())
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropForShadowNodeSetterTest.kt
+2
View File
@@ -11,6 +11,7 @@ import com.facebook.react.bridge.BridgeReactContext
import com.facebook.react.bridge.JavaOnlyMap
import com.facebook.react.bridge.ReadableArray
import com.facebook.react.bridge.ReadableMap
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.uimanager.annotations.ReactProp
import com.facebook.react.uimanager.annotations.ReactPropGroup
import com.facebook.testutils.shadows.ShadowSoLoader
@@ -101,6 +102,7 @@ class ReactPropForShadowNodeSetterTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
yogaNodeFactory = mockStatic(YogaNodeFactory::class.java)
yogaNodeFactory
.`when`<YogaNode> { YogaNodeFactory.create(any()) }
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropForShadowNodeSpecTest.kt
+2
View File
@@ -8,6 +8,7 @@
package com.facebook.react.uimanager
import android.view.View
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.uimanager.annotations.ReactProp
import com.facebook.react.uimanager.annotations.ReactPropGroup
import com.facebook.testutils.shadows.ShadowSoLoader
@@ -39,6 +40,7 @@ class ReactPropForShadowNodeSpecTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
yogaNodeFactory = mockStatic(YogaNodeFactory::class.java)
yogaNodeFactory
.`when`<YogaNode> { YogaNodeFactory.create(any()) }
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/SimpleViewPropertyTest.kt
+2
View File
@@ -17,6 +17,7 @@ import com.facebook.react.bridge.CatalystInstance
import com.facebook.react.bridge.JavaOnlyMap
import com.facebook.react.bridge.ReactTestHelper.createMockCatalystInstance
import com.facebook.react.bridge.ReadableMap
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import com.facebook.react.touch.JSResponderHandler
import com.facebook.react.uimanager.annotations.ReactProp
import org.assertj.core.api.Assertions
@@ -55,6 +56,7 @@ class SimpleViewPropertyTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
context = BridgeReactContext(RuntimeEnvironment.getApplication())
catalystInstanceMock = createMockCatalystInstance()
context.initializeWithInstance(catalystInstanceMock)
packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleConstantsHelperTest.kt
+8
View File
@@ -7,10 +7,18 @@
package com.facebook.react.uimanager
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
import org.assertj.core.api.Assertions.assertThat
import org.junit.Before
import org.junit.Test
class UIManagerModuleConstantsHelperTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
}
@Test
fun normalizeEventTypes_withNull_doesNothing() {
assertThat(UIManagerModuleConstantsHelper.normalizeEventTypes(null)).isNull()