Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

delete ShadowNodeFamily::instanceHandle_ (#41513)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41513

changelog: [internal]

Reviewed By: christophpurrer

Differential Revision: D51394187

fbshipit-source-id: 3add711a3954ba16bf4524d47c3ed67473e2c0eb
This commit is contained in:
Samuel Susla
2023-11-17 03:27:51 -08:00
committed by Facebook GitHub Bot
parent f4e9827013
commit a5d8ea4579
3 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp
+1 -6
View File
@@ -173,12 +173,7 @@ const SharedEventEmitter& ShadowNode::getEventEmitter() const {
}
jsi::Value ShadowNode::getInstanceHandle(jsi::Runtime& runtime) const {
auto instanceHandle = family_->instanceHandle_;
if (instanceHandle == nullptr) {
return jsi::Value::null();
}
return instanceHandle->getInstanceHandle(runtime);
return family_->eventEmitter_->getEventTarget()->getInstanceHandle(runtime);
}
Tag ShadowNode::getTag() const {
packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFamily.cpp
-1
View File
@@ -26,7 +26,6 @@ ShadowNodeFamily::ShadowNodeFamily(
: eventDispatcher_(std::move(eventDispatcher)),
tag_(fragment.tag),
surfaceId_(fragment.surfaceId),
instanceHandle_(fragment.instanceHandle),
eventEmitter_(std::move(eventEmitter)),
componentDescriptor_(componentDescriptor),
componentHandle_(componentDescriptor.getComponentHandle()),
packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFamily.h
-5
View File
@@ -132,11 +132,6 @@ class ShadowNodeFamily final {
*/
const SurfaceId surfaceId_;
/*
* Weak reference to the React instance handle
*/
InstanceHandle::Shared const instanceHandle_;
/*
* `EventEmitter` associated with all nodes of the family.
*/