mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Enable prepared text layout by default (#59152)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/59152 Turn on caching of text layout artifacts for later reuse and the Android text measurement optimizations by default, and raise the prepared layout cache size from 200 to 1000 entries. Overflow-hidden text default was already on and is unchanged. Changelog: [General][Changed] - Enable prepared text layout caching and Android text measurement optimizations by default Reviewed By: christophpurrer Differential Revision: D125768089 fbshipit-source-id: 0e4159719e99adda48e7e44b6e56159d9360735f
This commit is contained in:
1 parent
4c103143c2
commit
a5cb48b2fc
5 files changed
+19
-17
No files matched your search
@@ -323,7 +323,9 @@ describe('<Text>', () => {
|
||||
});
|
||||
|
||||
expect(root.getRenderedOutput({props: ['selectable']}).toJSX()).toEqual(
|
||||
<rn-paragraph selectable={'true'}>{TEST_TEXT}</rn-paragraph>,
|
||||
<rn-selectableParagraph selectable={'true'}>
|
||||
{TEST_TEXT}
|
||||
</rn-selectableParagraph>,
|
||||
);
|
||||
});
|
||||
|
||||
|
||||
+4
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<0151a6981c002284da2c1415de4e968e>>
|
||||
* @generated SignedSource<<cd6aa804d1c10b93775adf83419368e3>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -55,7 +55,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun enableAndroidAutoOffscreenCompositingForElevation(): Boolean = false
|
||||
|
||||
override fun enableAndroidTextMeasurementOptimizations(): Boolean = false
|
||||
override fun enableAndroidTextMeasurementOptimizations(): Boolean = true
|
||||
|
||||
override fun enableAsyncDiskCacheCheckInMultiSourceImageAndroid(): Boolean = false
|
||||
|
||||
@@ -119,7 +119,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun enablePreallocatedPropsDiffOnInsertAndroid(): Boolean = false
|
||||
|
||||
override fun enablePreparedTextLayout(): Boolean = false
|
||||
override fun enablePreparedTextLayout(): Boolean = true
|
||||
|
||||
override fun enablePropsUpdateReconciliationAndroid(): Boolean = false
|
||||
|
||||
@@ -167,7 +167,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun perfMonitorV2Enabled(): Boolean = false
|
||||
|
||||
override fun preparedTextCacheSize(): Double = 200.0
|
||||
override fun preparedTextCacheSize(): Double = 1000.0
|
||||
|
||||
override fun preventShadowTreeCommitExhaustion(): Boolean = false
|
||||
|
||||
|
||||
+4
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<474469c92e08f5eff4efc126bb2b7db9>>
|
||||
* @generated SignedSource<<46e48274f8b27b9c6136b13048682252>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -94,7 +94,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
}
|
||||
|
||||
bool enableAndroidTextMeasurementOptimizations() override {
|
||||
return false;
|
||||
return true;
|
||||
}
|
||||
|
||||
bool enableAsyncDiskCacheCheckInMultiSourceImageAndroid() override {
|
||||
@@ -222,7 +222,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
}
|
||||
|
||||
bool enablePreparedTextLayout() override {
|
||||
return false;
|
||||
return true;
|
||||
}
|
||||
|
||||
bool enablePropsUpdateReconciliationAndroid() override {
|
||||
@@ -318,7 +318,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
}
|
||||
|
||||
double preparedTextCacheSize() override {
|
||||
return 200.0;
|
||||
return 1000.0;
|
||||
}
|
||||
|
||||
bool preventShadowTreeCommitExhaustion() override {
|
||||
|
||||
@@ -226,7 +226,7 @@ const definitions: FeatureFlagDefinitions = {
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
enableAndroidTextMeasurementOptimizations: {
|
||||
defaultValue: false,
|
||||
defaultValue: true,
|
||||
metadata: {
|
||||
dateAdded: '2025-07-01',
|
||||
description:
|
||||
@@ -567,7 +567,7 @@ const definitions: FeatureFlagDefinitions = {
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
enablePreparedTextLayout: {
|
||||
defaultValue: false,
|
||||
defaultValue: true,
|
||||
metadata: {
|
||||
dateAdded: '2025-05-01',
|
||||
description: 'Enables caching text layout artifacts for later reuse',
|
||||
@@ -827,10 +827,10 @@ const definitions: FeatureFlagDefinitions = {
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
preparedTextCacheSize: {
|
||||
defaultValue: 200,
|
||||
defaultValue: 1000,
|
||||
metadata: {
|
||||
description: 'Number cached PreparedLayouts in TextLayoutManager cache',
|
||||
expectedReleaseValue: 200,
|
||||
expectedReleaseValue: 1000,
|
||||
purpose: 'operational',
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<721554b73a49d12b6cc4be542c81ec07>>
|
||||
* @generated SignedSource<<9d10bd1b003d8b0de95141f5676877a2>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -288,7 +288,7 @@ export const enableAndroidAutoOffscreenCompositingForElevation: Getter<boolean>
|
||||
/**
|
||||
* Enables various optimizations throughout the path of measuring text on Android.
|
||||
*/
|
||||
export const enableAndroidTextMeasurementOptimizations: Getter<boolean> = createNativeFlagGetter('enableAndroidTextMeasurementOptimizations', false);
|
||||
export const enableAndroidTextMeasurementOptimizations: Getter<boolean> = createNativeFlagGetter('enableAndroidTextMeasurementOptimizations', true);
|
||||
/**
|
||||
* Runs multi-source image disk-cache checks asynchronously on Android.
|
||||
*/
|
||||
@@ -416,7 +416,7 @@ export const enablePreallocatedPropsDiffOnInsertAndroid: Getter<boolean> = creat
|
||||
/**
|
||||
* Enables caching text layout artifacts for later reuse
|
||||
*/
|
||||
export const enablePreparedTextLayout: Getter<boolean> = createNativeFlagGetter('enablePreparedTextLayout', false);
|
||||
export const enablePreparedTextLayout: Getter<boolean> = createNativeFlagGetter('enablePreparedTextLayout', true);
|
||||
/**
|
||||
* When enabled, Android will receive prop updates based on the differences between the last rendered shadow node and the last committed shadow node.
|
||||
*/
|
||||
@@ -512,7 +512,7 @@ export const perfMonitorV2Enabled: Getter<boolean> = createNativeFlagGetter('per
|
||||
/**
|
||||
* Number cached PreparedLayouts in TextLayoutManager cache
|
||||
*/
|
||||
export const preparedTextCacheSize: Getter<number> = createNativeFlagGetter('preparedTextCacheSize', 200);
|
||||
export const preparedTextCacheSize: Getter<number> = createNativeFlagGetter('preparedTextCacheSize', 1000);
|
||||
/**
|
||||
* Enables a new mechanism in ShadowTree to prevent problems caused by multiple threads trying to commit concurrently. If a thread tries to commit a few times unsuccessfully, it will acquire a lock and try again.
|
||||
*/
|
||||
|
||||
Reference in new issue
Block a user