Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable vector drawable support by default (#48347)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/48347

Vector drawable support was added behind a feature flag in https://github.com/facebook/react-native/pull/45354 and is ready to release more widely. This change is effectively the same as removing the feature flag but allows our holdout to continue until mid-January.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D67482531

fbshipit-source-id: 1733c4748f79fd4df72f531a24efcbd8a7822611
This commit is contained in:
Peter Abbondanzo
2024-12-30 14:32:55 -08:00
committed by Facebook GitHub Bot
parent 6dd4195d2d
commit a3c8e21370
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
+2 -2
View File
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d21071fcbf501d1e7aba6b227ef74351>>
* @generated SignedSource<<ad4ecf46a017b05a22046b772504f889>>
*/
/**
@@ -95,7 +95,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
override fun lazyAnimationCallbacks(): Boolean = false
override fun loadVectorDrawablesOnImages(): Boolean = false
override fun loadVectorDrawablesOnImages(): Boolean = true
override fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean = false
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
+2 -2
View File
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<14f964cf6d43943bdeed783d28c231e0>>
* @generated SignedSource<<570853d015d4f41ef4eb0a7896a96e96>>
*/
/**
@@ -172,7 +172,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}
bool loadVectorDrawablesOnImages() override {
return false;
return true;
}
bool traceTurboModulePromiseRejectionsOnAndroid() override {
packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
+1 -1
View File
@@ -391,7 +391,7 @@ const definitions: FeatureFlagDefinitions = {
},
},
loadVectorDrawablesOnImages: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2024-07-12',
description:
packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
Vendored
+2 -2
View File
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<a35c5b22c0f20cb50ceaf56a856c9c8f>>
* @generated SignedSource<<fb2e049d649b9bf7ef6bd0e26523b4ef>>
* @flow strict
*/
@@ -337,7 +337,7 @@ export const lazyAnimationCallbacks: Getter<boolean> = createNativeFlagGetter('l
/**
* Adds support for loading vector drawable assets in the Image component (only on Android)
*/
export const loadVectorDrawablesOnImages: Getter<boolean> = createNativeFlagGetter('loadVectorDrawablesOnImages', false);
export const loadVectorDrawablesOnImages: Getter<boolean> = createNativeFlagGetter('loadVectorDrawablesOnImages', true);
/**
* Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
*/