mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Drop unused Hermes import from RCTAppSetupUtils (#58056)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58056 `RCTAppSetupUtils.h` imports `<reacthermes/HermesExecutorFactory.h>` but names nothing from it, so the import and the conditional that wrapped only it are removed. This unblocks classifying the Hermes executor as a private target under the three-tier C++ stable API visibility model, which it cannot be while a public header reaches it. Code that relied on reaching `HermesExecutorFactory` through this header should import it directly. Changelog: [iOS][Changed] - `RCTAppSetupUtils.h` no longer transitively imports `HermesExecutorFactory.h` Reviewed By: javache Differential Revision: D116934198 fbshipit-source-id: f1d6c82cb658cfdbc0581b6132ae3516982a1b75
This commit is contained in:
1 parent
25c5539ee4
commit
a385cecbea
1 file changed
-4
@@ -13,10 +13,6 @@
|
||||
|
||||
#import <memory>
|
||||
|
||||
#if USE_THIRD_PARTY_JSC != 1
|
||||
#import <reacthermes/HermesExecutorFactory.h>
|
||||
#endif
|
||||
|
||||
#import <ReactCommon/RCTTurboModuleManager.h>
|
||||
#import <jsireact/JSIExecutor.h>
|
||||
|
||||
|
||||
Reference in new issue
Block a user