mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix: textTransform not working in new arch (#41223)
Summary: Fixes: https://github.com/facebook/react-native/issues/39524 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [FIXED] - Fix textTransform not working in new architecture Pull Request resolved: https://github.com/facebook/react-native/pull/41223 Test Plan: **Before:** <img width="307" alt="image" src="https://github.com/facebook/react-native/assets/34857453/d44e6030-0a49-42c9-be44-cf7541583af0"> **After:** <img width="307" alt="image" src="https://github.com/facebook/react-native/assets/34857453/fb717cec-72d3-41d7-8c48-4ec9a9ecb16b"> Reviewed By: javache Differential Revision: D50773216 Pulled By: NickGerleman fbshipit-source-id: 769bf67f2661ff4ff7b88121493bdd27564458d3
This commit is contained in:
committed by
Facebook GitHub Bot
parent
a4edaf23cb
commit
a2f3fa65bc
+4
-1
@@ -59,6 +59,7 @@ public class TextAttributeProps {
|
||||
public static final short TA_KEY_ACCESSIBILITY_ROLE = 24;
|
||||
public static final short TA_KEY_LINE_BREAK_STRATEGY = 25;
|
||||
public static final short TA_KEY_ROLE = 26;
|
||||
public static final short TA_KEY_TEXT_TRANSFORM = 27;
|
||||
|
||||
public static final int UNSET = -1;
|
||||
|
||||
@@ -217,6 +218,9 @@ public class TextAttributeProps {
|
||||
case TA_KEY_ROLE:
|
||||
result.setRole(Role.values()[entry.getIntValue()]);
|
||||
break;
|
||||
case TA_KEY_TEXT_TRANSFORM:
|
||||
result.setTextTransform(entry.getStringValue());
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -224,7 +228,6 @@ public class TextAttributeProps {
|
||||
// setNumberOfLines
|
||||
// setColor
|
||||
// setIncludeFontPadding
|
||||
// setTextTransform
|
||||
return result;
|
||||
}
|
||||
|
||||
|
||||
@@ -970,6 +970,7 @@ constexpr static MapBuffer::Key TA_KEY_LAYOUT_DIRECTION = 23;
|
||||
constexpr static MapBuffer::Key TA_KEY_ACCESSIBILITY_ROLE = 24;
|
||||
constexpr static MapBuffer::Key TA_KEY_LINE_BREAK_STRATEGY = 25;
|
||||
constexpr static MapBuffer::Key TA_KEY_ROLE = 26;
|
||||
constexpr static MapBuffer::Key TA_KEY_TEXT_TRANSFORM = 27;
|
||||
|
||||
// constants for ParagraphAttributes serialization
|
||||
constexpr static MapBuffer::Key PA_KEY_MAX_NUMBER_OF_LINES = 0;
|
||||
@@ -1077,6 +1078,11 @@ inline MapBuffer toMapBuffer(const TextAttributes& textAttributes) {
|
||||
TA_KEY_LINE_BREAK_STRATEGY,
|
||||
toString(*textAttributes.lineBreakStrategy));
|
||||
}
|
||||
if (textAttributes.textTransform.has_value()) {
|
||||
builder.putString(
|
||||
TA_KEY_TEXT_TRANSFORM, toString(*textAttributes.textTransform));
|
||||
}
|
||||
|
||||
// Decoration
|
||||
if (textAttributes.textDecorationColor) {
|
||||
builder.putInt(
|
||||
|
||||
Reference in New Issue
Block a user