Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add NonNull annotation to FabricUIManager API

Browse Source 
Summary:
This diff annotates FabricUIManager class with NonNull annotations, this will help analysis of nullability plus improving integration with Kotlin clients

Changelog: Add NonNull annotation to FabricUIManager API

Reviewed By: JoshuaGross

Differential Revision: D18010917

fbshipit-source-id: 760ba04b78693cb184172c0fe613c7f808a49031
This commit is contained in:
David Vacca
2019-10-25 15:11:53 -07:00
committed by Facebook Github Bot
parent a8ce2dcf89
commit a1a56fe4e5
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
+6 -6
View File
@@ -83,7 +83,7 @@ import java.util.concurrent.ConcurrentHashMap;
@SuppressLint("MissingNativeLoadLibrary")
public class FabricUIManager implements UIManager, LifecycleEventListener {
public static final String TAG = FabricUIManager.class.getSimpleName();
public static final String TAG = "FabricUIManager";
public static final boolean DEBUG =
ReactFeatureFlags.enableFabricLogs
|| PrinterHolder.getPrinter()
@@ -401,9 +401,9 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
@SuppressWarnings("unused")
private long measure(
String componentName,
ReadableMap localData,
ReadableMap props,
ReadableMap state,
@NonNull ReadableMap localData,
@NonNull ReadableMap props,
@NonNull ReadableMap state,
float minWidth,
float maxWidth,
float minHeight,
@@ -422,7 +422,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
@Override
@ThreadConfined(UI)
public void synchronouslyUpdateViewOnUIThread(int reactTag, ReadableMap props) {
public void synchronouslyUpdateViewOnUIThread(int reactTag, @NonNull ReadableMap props) {
UiThreadUtil.assertOnUiThread();
long time = SystemClock.uptimeMillis();
int commitNumber = mCurrentSynchronousCommitNumber++;
@@ -447,7 +447,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
@DoNotStrip
@SuppressWarnings("unused")
private void scheduleMountItem(
final MountItem mountItem,
@NonNull final MountItem mountItem,
int commitNumber,
long commitStartTime,
long diffStartTime,