From a1a56fe4e5ca6214fe10a5925fcfb3222573206b Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 25 Oct 2019 15:07:18 -0700 Subject: [PATCH] Add NonNull annotation to FabricUIManager API Summary: This diff annotates FabricUIManager class with NonNull annotations, this will help analysis of nullability plus improving integration with Kotlin clients Changelog: Add NonNull annotation to FabricUIManager API Reviewed By: JoshuaGross Differential Revision: D18010917 fbshipit-source-id: 760ba04b78693cb184172c0fe613c7f808a49031 --- .../com/facebook/react/fabric/FabricUIManager.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index e1e39dd2a40..139be92fcac 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -83,7 +83,7 @@ import java.util.concurrent.ConcurrentHashMap; @SuppressLint("MissingNativeLoadLibrary") public class FabricUIManager implements UIManager, LifecycleEventListener { - public static final String TAG = FabricUIManager.class.getSimpleName(); + public static final String TAG = "FabricUIManager"; public static final boolean DEBUG = ReactFeatureFlags.enableFabricLogs || PrinterHolder.getPrinter() @@ -401,9 +401,9 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { @SuppressWarnings("unused") private long measure( String componentName, - ReadableMap localData, - ReadableMap props, - ReadableMap state, + @NonNull ReadableMap localData, + @NonNull ReadableMap props, + @NonNull ReadableMap state, float minWidth, float maxWidth, float minHeight, @@ -422,7 +422,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { @Override @ThreadConfined(UI) - public void synchronouslyUpdateViewOnUIThread(int reactTag, ReadableMap props) { + public void synchronouslyUpdateViewOnUIThread(int reactTag, @NonNull ReadableMap props) { UiThreadUtil.assertOnUiThread(); long time = SystemClock.uptimeMillis(); int commitNumber = mCurrentSynchronousCommitNumber++; @@ -447,7 +447,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { @DoNotStrip @SuppressWarnings("unused") private void scheduleMountItem( - final MountItem mountItem, + @NonNull final MountItem mountItem, int commitNumber, long commitStartTime, long diffStartTime,