mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
deprecate hasConstants from ReactModuleInfo (#39459)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39459 ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824 fbshipit-source-id: 1a4d36b3153d8ce0ee869b8635c94005fe7c9594
This commit is contained in:
Phillip Pan
committed by
Facebook GitHub Bot
Facebook GitHub Bot
parent
49197411d8
commit
9f52378cc1
-1
@@ -79,7 +79,6 @@ public class ReactRootViewTest {
|
||||
moduleClass.getName(),
|
||||
reactModule.canOverrideExistingModule(),
|
||||
reactModule.needsEagerInit(),
|
||||
reactModule.hasConstants(),
|
||||
reactModule.isCxxModule(),
|
||||
false));
|
||||
|
||||
|
||||
-1
@@ -114,7 +114,6 @@ public class CoreModulesPackage extends TurboReactPackage implements ReactPackag
|
||||
moduleClass.getName(),
|
||||
reactModule.canOverrideExistingModule(),
|
||||
reactModule.needsEagerInit(),
|
||||
reactModule.hasConstants(),
|
||||
reactModule.isCxxModule(),
|
||||
TurboModule.class.isAssignableFrom(moduleClass)));
|
||||
}
|
||||
|
||||
-1
@@ -73,7 +73,6 @@ public class DebugCorePackage extends TurboReactPackage implements ViewManagerOn
|
||||
moduleClass.getName(),
|
||||
reactModule.canOverrideExistingModule(),
|
||||
reactModule.needsEagerInit(),
|
||||
reactModule.hasConstants(),
|
||||
reactModule.isCxxModule(),
|
||||
TurboModule.class.isAssignableFrom(moduleClass)));
|
||||
}
|
||||
|
||||
-2
@@ -108,7 +108,6 @@ public abstract class ReactPackageTurboModuleManagerDelegate extends TurboModule
|
||||
moduleClass.getName(),
|
||||
reactModule.canOverrideExistingModule(),
|
||||
true,
|
||||
reactModule.hasConstants(),
|
||||
reactModule.isCxxModule(),
|
||||
TurboModule.class.isAssignableFrom(moduleClass))
|
||||
: new ReactModuleInfo(
|
||||
@@ -116,7 +115,6 @@ public abstract class ReactPackageTurboModuleManagerDelegate extends TurboModule
|
||||
moduleClass.getName(),
|
||||
module.canOverrideExistingModule(),
|
||||
true,
|
||||
true,
|
||||
CxxModuleWrapper.class.isAssignableFrom(moduleClass),
|
||||
TurboModule.class.isAssignableFrom(moduleClass));
|
||||
|
||||
|
||||
-1
@@ -71,7 +71,6 @@ public class ModuleHolder {
|
||||
nativeModule.getClass().getSimpleName(),
|
||||
nativeModule.canOverrideExistingModule(),
|
||||
true,
|
||||
true,
|
||||
CxxModuleWrapper.class.isAssignableFrom(nativeModule.getClass()),
|
||||
TurboModule.class.isAssignableFrom(nativeModule.getClass()));
|
||||
|
||||
|
||||
+16
-1
@@ -25,7 +25,6 @@ public class ReactModuleInfo {
|
||||
String className,
|
||||
boolean canOverrideExistingModule,
|
||||
boolean needsEagerInit,
|
||||
boolean hasConstants,
|
||||
boolean isCxxModule,
|
||||
boolean isTurboModule) {
|
||||
mName = name;
|
||||
@@ -36,6 +35,22 @@ public class ReactModuleInfo {
|
||||
mIsTurboModule = isTurboModule;
|
||||
}
|
||||
|
||||
/**
|
||||
* @deprecated use {@link ReactModuleInfo#ReactModuleInfo(String, String, boolean, boolean,
|
||||
* boolean, boolean)}
|
||||
*/
|
||||
@Deprecated
|
||||
public ReactModuleInfo(
|
||||
String name,
|
||||
String className,
|
||||
boolean canOverrideExistingModule,
|
||||
boolean needsEagerInit,
|
||||
boolean hasConstants,
|
||||
boolean isCxxModule,
|
||||
boolean isTurboModule) {
|
||||
this(name, className, canOverrideExistingModule, needsEagerInit, isCxxModule, isTurboModule);
|
||||
}
|
||||
|
||||
public String name() {
|
||||
return mName;
|
||||
}
|
||||
|
||||
-2
@@ -228,8 +228,6 @@ public class ReactModuleSpecProcessor extends AbstractProcessor {
|
||||
.append(", ")
|
||||
.append(reactModule.needsEagerInit())
|
||||
.append(", ")
|
||||
.append(hasConstants)
|
||||
.append(", ")
|
||||
.append(reactModule.isCxxModule())
|
||||
.append(", ")
|
||||
.append(isTurboModule)
|
||||
|
||||
-1
@@ -97,7 +97,6 @@ class CoreReactPackage extends TurboReactPackage {
|
||||
moduleClass.getName(),
|
||||
reactModule.canOverrideExistingModule(),
|
||||
reactModule.needsEagerInit(),
|
||||
reactModule.hasConstants(),
|
||||
reactModule.isCxxModule(),
|
||||
TurboModule.class.isAssignableFrom(moduleClass)));
|
||||
}
|
||||
|
||||
-3
@@ -283,7 +283,6 @@ public class MainReactPackage extends TurboReactPackage implements ViewManagerOn
|
||||
final Map<String, ReactModuleInfo> reactModuleInfoMap = new HashMap<>();
|
||||
for (Class<? extends NativeModule> moduleClass : moduleList) {
|
||||
ReactModule reactModule = moduleClass.getAnnotation(ReactModule.class);
|
||||
|
||||
if (reactModule != null) {
|
||||
reactModuleInfoMap.put(
|
||||
reactModule.name(),
|
||||
@@ -292,12 +291,10 @@ public class MainReactPackage extends TurboReactPackage implements ViewManagerOn
|
||||
moduleClass.getName(),
|
||||
reactModule.canOverrideExistingModule(),
|
||||
reactModule.needsEagerInit(),
|
||||
reactModule.hasConstants(),
|
||||
reactModule.isCxxModule(),
|
||||
TurboModule.class.isAssignableFrom(moduleClass)));
|
||||
}
|
||||
}
|
||||
|
||||
return () -> reactModuleInfoMap;
|
||||
} catch (InstantiationException e) {
|
||||
throw new RuntimeException(
|
||||
|
||||
-2
@@ -102,7 +102,6 @@ public class RNTesterApplication extends Application implements ReactApplication
|
||||
"SampleTurboModule",
|
||||
false, // canOverrideExistingModule
|
||||
false, // needsEagerInit
|
||||
true, // hasConstants
|
||||
false, // isCxxModule
|
||||
true // isTurboModule
|
||||
));
|
||||
@@ -114,7 +113,6 @@ public class RNTesterApplication extends Application implements ReactApplication
|
||||
"SampleLegacyModule",
|
||||
false, // canOverrideExistingModule
|
||||
false, // needsEagerInit
|
||||
true, // hasConstants
|
||||
false, // isCxxModule
|
||||
false // isTurboModule
|
||||
));
|
||||
|
||||
-2
@@ -90,7 +90,6 @@ class RNTesterReactHostDelegate internal constructor(context: Context) : ReactHo
|
||||
"SampleTurboModule",
|
||||
false, // canOverrideExistingModule
|
||||
false, // needsEagerInit
|
||||
true, // hasConstants
|
||||
false, // isCxxModule
|
||||
true // isTurboModule
|
||||
),
|
||||
@@ -100,7 +99,6 @@ class RNTesterReactHostDelegate internal constructor(context: Context) : ReactHo
|
||||
"SampleLegacyModule",
|
||||
false, // canOverrideExistingModule
|
||||
false, // needsEagerInit
|
||||
true, // hasConstants
|
||||
false, // isCxxModule
|
||||
false // isTurboModule
|
||||
),
|
||||
|
||||
Reference in New Issue
Block a user