mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix iOS E2E Tests (#48400)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48400 A couple of days ago, the iOS CI started failing for the E2E tests on main. This is because We were not using the hermes artifacts we were preconfiguring. In fact, this is the log of the `test_e2e_ios_rntester`, which is not using the prebuilt. {F1974129000} For comparison, this is the `test_ios_rntester`, which is using the prebuilt {F1974129001} While investigating why this was happening, I realized that we were not testing the old architecture anymore, because we forget to update the script after the release of the New Architecture. This change should fix both. ## Changelog: [Internal] - Fix E2E tests for iOS and test the Old Arch Reviewed By: robhogan Differential Revision: D67670976 fbshipit-source-id: 7d1383a89e06c138f437a9c5f876a2e900878fb0
This commit is contained in:
committed by
Facebook GitHub Bot
parent
44705fe11b
commit
9ceabd341d
@@ -109,8 +109,8 @@ runs:
|
||||
export USE_FRAMEWORKS=dynamic
|
||||
fi
|
||||
|
||||
if [[ ${{ inputs.architecture }} == "NewArch" ]]; then
|
||||
export RCT_NEW_ARCH_ENABLED=1
|
||||
if [[ ${{ inputs.architecture }} == "OldArch" ]]; then
|
||||
export RCT_NEW_ARCH_ENABLED=0
|
||||
fi
|
||||
|
||||
cd packages/rn-tester
|
||||
|
||||
Reference in New Issue
Block a user